Google Git
Sign in
chromium / chromium / tools / build / 1577bf430461dcc888f92d7fe851c40c15e9a3ee
commit1577bf430461dcc888f92d7fe851c40c15e9a3ee[log] [tgz]
authorMirko Bonadei <mbonadei@chromium.org>Fri Nov 20 19:24:35 2020
committerLUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Nov 20 19:24:35 2020
tree903d5f8a97955fad52581b19905848d793cd43b2
parent8c0facde082959d05636b6931a69bd98dee40986 [diff]
Avoid to json encode test_args.

This seems to cause problems with flags forwarding to the binary
under test (see bugs.webrtc.org/12213#c2).

As reported on the bug, "test_args" was a list of strings but after
https://chromium-review.googlesource.com/c/chromium/tools/build/+/2518615
it is a string.

Bug: webrtc:12213
Change-Id: I047a8bd0b9a8f9e32651b5111b1699c3fdcf1ffb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/build/+/2550654
Reviewed-by: Jeff Yoon <jeffyoon@google.com>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
4 files changed
tree: 903d5f8a97955fad52581b19905848d793cd43b2
  1. infra/
  2. recipes/
  3. scripts/
  4. site_config/
  5. third_party/
  6. .gitattributes
  7. .gitignore
  8. .style.yapf
  9. .vpython
  10. .yapfignore
  11. codereview.settings
  12. CROS_OWNERS
  13. DEPS
  14. environment.cfg.py
  15. LICENSE
  16. OWNERS
  17. PRESUBMIT.py
  18. README.md
  19. WATCHLISTS
README.md

Recipes

If you're here to make a change to ‘recipes’ (the code located in scripts/slave/recipes*), please take a look at the README for more information pertaining to recipes.

Style

The preferred style is PEP8 with two-space indent; that is, the Chromium Python style. Functions use lowercase_with_underscores, with the exception of the special functions RunSteps and RunTests in recipes. Use yapf (git cl format --no-clang-format) to autoformat new code.