Replace DidGetUserGesture with DidGetUserInteraction in the download request limiter.

Replace DidGetUserGesture with DidGetUserInteraction in the download request limiter.

User gestures such as clicks, gesture taps, and keyboard enter or space
are currently used as signals in the download request limiter that the
user is interacting with a page and therefore will accept a download
from the page. These gestures are currently signaled via
WebContentsObserver::DidGetUserGesture.

This CL replaces DidGetUserGesture with DidGetUserInteraction, which
triggers on all keyboard events and scrolls in addition to clicks and
taps. The latter method has a simpler implementation in content, signals
the type of interaction that triggered it, and is replacing the older
DidGetUserGesture method, of which the download request limiter is one
of only two clients. Scrolls are ignored, but other gestures are
accepted by the limiter (with tests updated to check this).

Functionally, the only change is that the limiter will now accept any
keyboard input as a gesture signal, rather than just enter or space.
This is appropriate as the gesture is being used as a heuristic for user
interaction with the page.

BUG=584154
Committed: https://crrev.com/71ad14d5cbffc802636071337a5db461357aae4c
Cr-Commit-Position: refs/heads/master@{#376865}

[dominickn, 2016-02-15 03:56:11]

dominickn@chromium.org changed reviewers:
+ asanka@chromium.org

[dominickn, 2016-02-15 03:56:11]

PTAL, thanks! rdsmith@ verbally okay'd this change, but he defers to your
judgement as a more recent owner of the code.

[dominickn, 2016-02-18 22:53:50]

Ping.

[asanka, 2016-02-22 22:16:50]

LGTM % comment update

https://codereview.chromium.org/1701593002/diff/40001/chrome/browser/download...
File chrome/browser/download/download_request_limiter.cc (right):

https://codereview.chromium.org/1701593002/diff/40001/chrome/browser/download...
chrome/browser/download/download_request_limiter.cc:104: // scrolled.
It seems the code is trying to avoid changing the state while showing a prompt,
rather than when the user clicks somewhere on the page. Update the comment?

[dominickn, 2016-02-22 23:39:26]

Thanks!

https://codereview.chromium.org/1701593002/diff/40001/chrome/browser/download...
File chrome/browser/download/download_request_limiter.cc (right):

https://codereview.chromium.org/1701593002/diff/40001/chrome/browser/download...
chrome/browser/download/download_request_limiter.cc:104: // scrolled.
On 2016/02/22 22:16:50, asanka wrote:
> It seems the code is trying to avoid changing the state while showing a
prompt,
> rather than when the user clicks somewhere on the page. Update the comment?

Done.

[dominickn, 2016-02-22 23:39:38]

The CQ bit was checked by dominickn@chromium.org

[dominickn, 2016-02-22 23:39:38]

The patchset sent to the CQ was uploaded after l-g-t-m from asanka@chromium.org
Link to the patchset: https://codereview.chromium.org/1701593002/#ps60001
(title: "Addressing reviewer comment")

[commit-bot: I haz the power, 2016-02-22 23:41:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1701593002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1701593002/60001

[commit-bot: I haz the power, 2016-02-23 00:24:29]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-02-23 00:25:39]

Description was changed from

==========
Replace DidGetUserGesture with DidGetUserInteraction in the download request
limiter.

User gestures such as clicks, gesture taps, and keyboard enter or space
are currently used as signals in the download request limiter that the
user is interacting with a page and therefore will accept a download
from the page. These gestures are currently signaled via
WebContentsObserver::DidGetUserGesture.

This CL replaces DidGetUserGesture with DidGetUserInteraction, which
triggers on all keyboard events and scrolls in addition to clicks and
taps. The latter method has a simpler implementation in content, signals
the type of interaction that triggered it, and is replacing the older
DidGetUserGesture method, of which the download request limiter is one
of only two clients. Scrolls are ignored, but other gestures are
accepted by the limiter (with tests updated to check this).

Functionally, the only change is that the limiter will now accept any
keyboard input as a gesture signal, rather than just enter or space.
This is appropriate as the gesture is being used as a heuristic for user
interaction with the page.

BUG=584154
==========

to

==========
Replace DidGetUserGesture with DidGetUserInteraction in the download request
limiter.

User gestures such as clicks, gesture taps, and keyboard enter or space
are currently used as signals in the download request limiter that the
user is interacting with a page and therefore will accept a download
from the page. These gestures are currently signaled via
WebContentsObserver::DidGetUserGesture.

This CL replaces DidGetUserGesture with DidGetUserInteraction, which
triggers on all keyboard events and scrolls in addition to clicks and
taps. The latter method has a simpler implementation in content, signals
the type of interaction that triggered it, and is replacing the older
DidGetUserGesture method, of which the download request limiter is one
of only two clients. Scrolls are ignored, but other gestures are
accepted by the limiter (with tests updated to check this).

Functionally, the only change is that the limiter will now accept any
keyboard input as a gesture signal, rather than just enter or space.
This is appropriate as the gesture is being used as a heuristic for user
interaction with the page.

BUG=584154

Committed: https://crrev.com/71ad14d5cbffc802636071337a5db461357aae4c
Cr-Commit-Position: refs/heads/master@{#376865}
==========

[commit-bot: I haz the power, 2016-02-23 00:25:40]

Patchset 4 (id:??) landed as
https://crrev.com/71ad14d5cbffc802636071337a5db461357aae4c
Cr-Commit-Position: refs/heads/master@{#376865}