commit | 171eed0b622e3252b8abe703a70b8d283267125d | [log] [tgz] |
---|---|---|
author | Adithya Srinivasan <adithyas@chromium.org> | Wed Sep 12 16:51:11 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Wed Sep 12 16:51:11 2018 |
tree | 88bbb83326c3c120aa32e1d56518e4edf47f1a9f | |
parent | a7dd3bd6af99ee62527148d9dfdb9eef8ef2c404 [diff] |
Revert "Listen to UsbDeviceManager instead of UsbService in UsbChooserContext." This reverts commit a0f301ad19908c1320f0b00d87f0469b6009b5a6. Reason for revert: Suspect that is causes test failures in Linux ASan, see https://crbug.com/883262. Original change's description: > Listen to UsbDeviceManager instead of UsbService in UsbChooserContext. > > For UsbService::Observer, "OnDeviceRemovedCleanup" needs to be handled > after "OnDeviceRemoved". But for mojom interface UsbDeviceManager, > there is no way to provide such dependency among listeners. > > As all users will be converted from UsbService to UsbDeviceManager, > to avoid the potential race condition, WebUsbServiceImpl is made > listen to UsbChooserContext in this CL. > > Bug: 699790 > Change-Id: I1e3b45196552e987b7422b127651e1fb01e1618b > Reviewed-on: https://chromium-review.googlesource.com/1210386 > Commit-Queue: Donna Wu <donna.wu@intel.com> > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#590609} TBR=reillyg@chromium.org,donna.wu@intel.com Change-Id: I954dd50c4cf8b5b761ede371f8ff904c07a61993 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 699790, 883262 Reviewed-on: https://chromium-review.googlesource.com/1222107 Reviewed-by: Adithya Srinivasan <adithyas@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#590720}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .