6bb19a6ed084dafd380a30c0098452acbc92fa6d - chromium/src

commit	6bb19a6ed084dafd380a30c0098452acbc92fa6d	[log] [tgz]
author	akalin@chromium.org <akalin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>	Thu Dec 13 04:28:33 2012
committer	akalin@chromium.org <akalin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>	Thu Dec 13 04:28:33 2012
tree	85f39471ddd69eefaa5bb3adcd77eb1633893263
parent	dedd11a1706e63fed812b5ffa67756402c99fc42 [diff]

[Sync] Add tests for invalid specifics field number handling

This is a follow up to r172232.

Change NOTREACHED() to DLOG(WARNING), since the server sending down
unknown/invalid field numbers is a valid event.

Add tests for the code that uses GetModelTypeFromSpecificsFieldNumber().

Clean up some code in sync/engine/ a bit.

BUG=165171


Review URL: https://chromiumcodereview.appspot.com/11485019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172816 0039d316-1c4b-4281-b951-d872f2087c98

sync/engine/DEPS[diff]
sync/engine/store_timestamps_command.cc[diff]
sync/engine/store_timestamps_command.h[diff]
sync/engine/store_timestamps_command_unittest.cc[Added - diff]
sync/engine/syncer_proto_util.cc[diff]
sync/engine/syncer_proto_util.h[diff]
sync/engine/syncer_proto_util_unittest.cc[diff]
sync/internal_api/public/base/model_type.h[diff]
sync/sync.gyp[diff]

9 files changed