commit | 177710b35ff924314959888407cbb117c5e67c95 | [log] [tgz] |
---|---|---|
author | Jamie Madill <jmadill@chromium.org> | Fri Jan 10 19:16:47 2020 |
committer | Commit Bot <commit-bot@chromium.org> | Fri Jan 10 19:16:47 2020 |
tree | a3998706ad61939f8163912d8c5a6b7c3661c8de | |
parent | fc132e61dbe484619d780ce9dedb08986a090706 [diff] |
Revert "git-cl: Fix format --dry-run not working with --full." This reverts commit fc132e61dbe484619d780ce9dedb08986a090706. Reason for revert: Causes all presubmit checks to return dirty format because of a non-zero diff output. Original change's description: > git-cl: Fix format --dry-run not working with --full. > > The --full option would skip setting the return value of the format > command when used with --dry-run. This in turn would cause the > presubmit check to always pass when --full was enabled in a repo by > default. > > Was discovered in the ANGLE repository. > > Bug: angleproject:4241 > Change-Id: Ie6cb423a6818c1e26781d77938a0dd22c02b4c16 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1987835 > Commit-Queue: Jamie Madill <jmadill@chromium.org> > Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> > Auto-Submit: Jamie Madill <jmadill@chromium.org> TBR=ehmaldonado@chromium.org,jmadill@chromium.org Change-Id: I0a4c51117ab20606f6dbb1f7a3ba40f87da1e939 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: angleproject:4241 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1993907 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Tools for working with Chromium development. It requires python 2.7.
The most important tools are:
fetch
: A gclient
wrapper to checkout a project. Use fetch --help
for more details.gclient
: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Use gclient help
for more details and README.gclient.md.git cl
: A code review tool to interact with Rietveld or Gerrit. Use git cl help
for more details and README.git-cl.md.roll-dep
: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.There are a lot of git utilities included.
depot_tools
updates itself automatically when running gclient
tool. To disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0
.
To update package manually, run update_depot_tools.bat
on Windows, or ./update_depot_tools
on Linux or Mac.
On Windows only, running gclient
will install git
and python
.
To contribute change for review:
git new-branch <somename> # Hack git add . git commit -a -m "Fixes goat teleporting" # find reviewers git cl owners git log -- <yourfiles> # Request a review. git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail # Edit change description if needed. git cl desc # If change is approved, flag it to be committed. git cl set-commit # If change needs more work. git rebase-update ... git cl upload -t "Fixes goat teleporter destination to be Australia"
See also open bugs, open reviews, forum or report problems.
Until 2018, our cpplint.py
was a copy of the upstream version at https://github.com/google/styleguide/tree/gh-pages/cpplint. Unfortunately, that repository is not maintained any more. If you want to update cpplint.py
in depot_tools
, just upload a patch to do so. We will figure out a long-term strategy via issue https://crbug.com/916550.
Note that the cpplint.py
here is also used by the Tricium analyzer, so if the cpplint.py here changes, we should also update the copy used there.