commit 178d6b18578c95cfbbe880e07f204c2dd316a114
author Dmitry Gozman <dgozman@chromium.org> Thu Dec 13 02:55:48 2018
committer Commit Bot <commit-bot@chromium.org> Thu Dec 13 02:55:48 2018
tree 1f2a03fd25725a4bcdf51a095463056dae4dd1d9
parent 2b4e11ccbd75e0341413d8ebae3e58298e79128b

Remove RenderFrameImpl::DidReceiveResponse

We already handle the main resource response during CommitNavigation.
The only missing bit was the fake "200" status code for data urls,
which we can set in BuildDocumentState.

This approach differs with existing one in the following cases:

1. Data urls committed as WebData (as opposite to a fake WebURLRequest)
   don't get 200 currently. This seems like a bug - we should either mark
   all data urls as 200, or none.

2. Due to browser-side navigation, DidReceiveResponse may encounter a
   placeholder document loader for some outstanding requests (e.g. favicon from
   previous load). This leads to using wrong alpn negotiated protocol and/or
   status code, which is definitely a bug.

3. Test-only path which skips RenderFrameImpl entirely for subframes when
   loading an html string - it does not set 200 for data urls. This is a
   test-only issue, which is again fixed with the new approach.

Bug: 855189
Change-Id: I5e2d0e539f9e5c3ad1a8af1153390dff2bfb678b
Reviewed-on: https://chromium-review.googlesource.com/c/1272135
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616182}