commit | 17fcfc1b874e9d40e6e0aff06f6affcfeb7035fa | [log] [tgz] |
---|---|---|
author | Matt Wolenetz <wolenetz@chromium.org> | Wed Sep 13 00:33:36 2017 |
committer | Commit Bot <commit-bot@chromium.org> | Wed Sep 13 00:33:36 2017 |
tree | 5146d733eeb01474b9a60a2b6d33ecca21a43947 | |
parent | bfe88542d3e3fd92c64c281207b46f13ab4a2513 [diff] |
MSE: Begin FrameProcessorTest'ing both old and new buffering APIs Previously, FrameProcessorTest had a boolean test parameter indicating whether or not to test using sequence append mode. This change adds a second dimension to the test parameter, which parameterizes the tests further by which version of the buffering API is being tested. The test ctor forces on/off the media::kMseBufferByPts feature accordingly. It no longer uses test ctor initializer to construct the FrameProcessor, since that must happen after adjusting enable/disable of the kMseBufferByPts feature later in the ctor. This change also captures the sequence mode boolean test parameter as a protected member, including related test cleanup to use that member instead of a local boolean or local GetParam() check. Three previous TEST_F (that did not need an append mode variation) are now TEST_P using the new FrameProcessorTestParams instantiations to keep this change simpler. BUG=718641 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I9210900a29382bded23e3701b39af733864fceb2 Reviewed-on: https://chromium-review.googlesource.com/663765 Reviewed-by: Dan Sanders <sandersd@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#501483}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .