| commit | 182740235efc11d585d6710485d66fff4fcf84ae | [log] [tgz] |
|---|---|---|
| author | tyoshino <tyoshino@chromium.org> | Wed May 31 01:49:24 2017 |
| committer | Commit Bot <commit-bot@chromium.org> | Wed May 31 01:49:36 2017 |
| tree | bcf0cb25eef95de4bfca61fbba48805d258222b1 | |
| parent | 77c59a87000dc29ebe28488b9302590081463f6e [diff] |
Revert of [DMC #17] Make TextMatchMarkers constructible in single step (patchset #4 id:60001 of https://codereview.chromium.org/2905753002/ ) Reason for revert: This broke the build. https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac%20Builder%20%28dbg%29/builds/201575 Original issue's description: > Make TextMatchMarkers constructible in single step > > Currently, we only construct instances of TextMatchMarker (previously > RenderedDocumentMarker) inside TextMatchMarkerListImpl, by calling > TextMatchMarker::Create() on an instance of DocumentMarker. This CL changes this > so callers directly construct instances of TextMatchMarker. This sets us up to > eventually move the storage and accessor methods for whether or not the marker > is active out of DocumentMarker and into TextMatchMarker. > > BUG=707867 > > Review-Url: https://codereview.chromium.org/2905753002 > Cr-Commit-Position: refs/heads/master@{#475724} > Committed: https://chromium.googlesource.com/chromium/src/+/6b0a494122ebe2fc48099a9549b0acbf0b28571d TBR=yosin@chromium.org,xiaochengh@chromium.org,rlanday@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=707867 Review-Url: https://codereview.chromium.org/2912133003 Cr-Commit-Position: refs/heads/master@{#475732}