Fix spurious profile shortcuts created with a system-level install.

This issue was caused by RenameChromeDesktopShortcutForProfile()
having logic to copy a system-level shortcut to make a user-level
shortcut in the case where a non-profile Chrome shortcut would
need to become a profile shortcut (i.e. the first user's profile
shortcut when creating a second user).

This path was being triggered by the initial change of the profile
avatar when the profile was created. The fix is to not to try
updating profile shortcuts on name/avatar changes when we know the
profile never had a shortcut created (by virtue of the shortcut
name never getting stored).

BUG=177047
TEST=On a system-level install, create a new profile with the "create
shortcut" checkbox unchecked. A shortcut should not be created. Change
the profile's name or icon. The shortcut should still not appear.
Review URL: https://codereview.chromium.org/12300036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@183348 0039d316-1c4b-4281-b951-d872f2087c98
2 files changed