Add OpenTypeCapsSupport class

Add OpenTypeCapsSupport class

As preparation for implementing correct font-variant-caps we need to be
able to check font files for their ability to support caps related
OpenType features, such as 'smcp', 'c2sc' etc.

The implementation files are split in two, one part Chromium-side
implementation, one part Mozilla Public License'd code adapted from
Firefox.

BUG=587094
TEST=OpenTypeCapsSupportTest.cpp
TBR=dpranke

Committed: https://crrev.com/530c73184ff5fed64d9dae5ff1d452d1a75d3a99
Cr-Commit-Position: refs/heads/master@{#387085}

[drott, 2016-04-12 12:57:27]

drott@chromium.org changed reviewers:
+ behdad@chromium.org, eae@chromium.org, kojii@chromium.org

[drott, 2016-04-12 12:57:32]

The CQ bit was checked by drott@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-12 12:57:41]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1882063002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1882063002/1

[eae, 2016-04-12 15:20:12]

LGTM

https://codereview.chromium.org/1882063002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/fonts/opentype/OpenTypeCapsSupport.cpp
(right):

https://codereview.chromium.org/1882063002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/fonts/opentype/OpenTypeCapsSupport.cpp:1: //
Copyright 2015 The Chromium Authors. All rights reserved.
2016

[commit-bot: I haz the power, 2016-04-12 15:33:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-12 15:33:51]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[behdad, 2016-04-13 05:32:50]

lgtm

https://codereview.chromium.org/1882063002/diff/1/third_party/WebKit/Source/p...
File
third_party/WebKit/Source/platform/fonts/opentype/OpenTypeCapsSupportMPL.cpp
(right):

https://codereview.chromium.org/1882063002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/fonts/opentype/OpenTypeCapsSupportMPL.cpp:65:
if (hb_ot_layout_table_find_script(face,
Using hb_ot_layout_table_choose_script instead of hb_ot_layout_table_find_script
simplifies the logic a bit, if you are up to updating for that.

[drott, 2016-04-13 15:13:20]

The CQ bit was checked by drott@chromium.org

[commit-bot: I haz the power, 2016-04-13 15:13:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1882063002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1882063002/1

[drott, 2016-04-13 15:15:12]

I can't reproduce the ASAN failures :-( even with a gn build for asan and
dcheck_always_on... :-( trying the CQ again.

>
https://codereview.chromium.org/1882063002/diff/1/third_party/WebKit/Source/p...
> File
third_party/WebKit/Source/platform/fonts/opentype/OpenTypeCapsSupportMPL.cpp
(right):
> 
>
https://codereview.chromium.org/1882063002/diff/1/third_party/WebKit/Source/p...
>
third_party/WebKit/Source/platform/fonts/opentype/OpenTypeCapsSupportMPL.cpp:65:
if (hb_ot_layout_table_find_script(face,
> Using hb_ot_layout_table_choose_script instead of
hb_ot_layout_table_find_script simplifies the logic a bit, if you are up to
updating for that.

I'll file a bug for it, I'd need a bit more info on how these calls differ and
what I should change, if you could help me with that.

[drott, 2016-04-13 16:56:35]

Adding used font files to .isolate recipe

[drott, 2016-04-13 16:58:19]

drott@chromium.org changed reviewers:
+ dpranke@chromium.org

[drott, 2016-04-13 16:58:21]

The CQ bit was checked by drott@chromium.org

[drott, 2016-04-13 16:58:22]

The patchset sent to the CQ was uploaded after l-g-t-m from eae@chromium.org,
behdad@chromium.org
Link to the patchset: https://codereview.chromium.org/1882063002/#ps20001
(title: "Adding used font files to .isolate recipe")

[commit-bot: I haz the power, 2016-04-13 16:58:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1882063002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1882063002/20001

[drott, 2016-04-13 16:59:30]

Dirk, I am committing this, with TBR=dpranke@ for the change in the .isolate
file.

[drott, 2016-04-13 16:59:45]

Description was changed from

==========
Add OpenTypeCapsSupport class

As preparation for implementing correct font-variant-caps we need to be
able to check font files for their ability to support caps related
OpenType features, such as 'smcp', 'c2sc' etc.

The implementation files are split in two, one part Chromium-side
implementation, one part Mozilla Public License'd code adapted from
Firefox.

BUG=587094
TEST=OpenTypeCapsSupportTest.cpp
==========

to

==========
Add OpenTypeCapsSupport class

As preparation for implementing correct font-variant-caps we need to be
able to check font files for their ability to support caps related
OpenType features, such as 'smcp', 'c2sc' etc.

The implementation files are split in two, one part Chromium-side
implementation, one part Mozilla Public License'd code adapted from
Firefox.

BUG=587094
TEST=OpenTypeCapsSupportTest.cpp
TBR=dpranke
==========

[drott, 2016-04-13 17:55:49]

Adding used font files to .isolate recipe, now with trailing slashes

[drott, 2016-04-13 17:56:05]

The CQ bit was checked by drott@chromium.org

[drott, 2016-04-13 17:56:06]

The patchset sent to the CQ was uploaded after l-g-t-m from eae@chromium.org,
behdad@chromium.org
Link to the patchset: https://codereview.chromium.org/1882063002/#ps40001
(title: "Adding used font files to .isolate recipe, now with trailing slashes")

[commit-bot: I haz the power, 2016-04-13 17:56:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1882063002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1882063002/40001

[Dirk Pranke, 2016-04-13 19:25:16]

lgtm. Sorry, I must've missed this earlier.

[drott, 2016-04-13 19:37:58]

On 2016/04/13 at 19:25:16, dpranke wrote:
> lgtm. Sorry, I must've missed this earlier.

Thanks & no worries, this didn't trigger earlier. I am just using fonts from
LayoutTest/third_party in this CL.

[commit-bot: I haz the power, 2016-04-13 21:06:36]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-13 21:07:39]

Description was changed from

==========
Add OpenTypeCapsSupport class

As preparation for implementing correct font-variant-caps we need to be
able to check font files for their ability to support caps related
OpenType features, such as 'smcp', 'c2sc' etc.

The implementation files are split in two, one part Chromium-side
implementation, one part Mozilla Public License'd code adapted from
Firefox.

BUG=587094
TEST=OpenTypeCapsSupportTest.cpp
TBR=dpranke
==========

to

==========
Add OpenTypeCapsSupport class

As preparation for implementing correct font-variant-caps we need to be
able to check font files for their ability to support caps related
OpenType features, such as 'smcp', 'c2sc' etc.

The implementation files are split in two, one part Chromium-side
implementation, one part Mozilla Public License'd code adapted from
Firefox.

BUG=587094
TEST=OpenTypeCapsSupportTest.cpp
TBR=dpranke

Committed: https://crrev.com/530c73184ff5fed64d9dae5ff1d452d1a75d3a99
Cr-Commit-Position: refs/heads/master@{#387085}
==========

[commit-bot: I haz the power, 2016-04-13 21:07:41]

Patchset 3 (id:??) landed as
https://crrev.com/530c73184ff5fed64d9dae5ff1d452d1a75d3a99
Cr-Commit-Position: refs/heads/master@{#387085}

[rjkroege, 2016-04-13 22:14:32]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1891613002/ by rjkroege@chromium.org.

The reason for reverting is: breaks layout tests on Linux

6 tests crashed:
    OpenTypeCapsSupportTest.LibertineAllPetiteSynthesis
(../../third_party/WebKit/Source/platform/fonts/opentype/OpenTypeCapsSupportTest.cpp:53)
    OpenTypeCapsSupportTest.LibertineIgnoreMissingTitling
(../../third_party/WebKit/Source/platform/fonts/opentype/OpenTypeCapsSupportTest.cpp:38)
    OpenTypeCapsSupportTest.LibertineSmcpC2scSupported
(../../third_party/WebKit/Source/platform/fonts/opentype/OpenTypeCapsSupportTest.cpp:23)
    OpenTypeCapsSupportTest.LibertineUnicaseFallback
(../../third_party/WebKit/Source/platform/fonts/opentype/OpenTypeCapsSupportTest.cpp:98)
    OpenTypeCapsSupportTest.MEgalopolisSmallCapsSynthetic
(../../third_party/WebKit/Source/platform/fonts/opentype/OpenTypeCapsSupportTest.cpp:68)
    OpenTypeCapsSupportTest.MEgalopolisUnicaseSynthetic
(../../third_party/WebKit/Source/platform/fonts/opentype/OpenTypeCapsSupportTest.cpp:83)
.

[Dirk Pranke, 2016-04-13 22:17:58]

On 2016/04/13 22:14:32, rjkroege wrote:
> A revert of this CL (patchset #3 id:40001) has been created in
> https://codereview.chromium.org/1891613002/ by mailto:rjkroege@chromium.org.
> 
> The reason for reverting is: breaks layout tests on Linux
> 
> 6 tests crashed:
>     OpenTypeCapsSupportTest.LibertineAllPetiteSynthesis
>
(../../third_party/WebKit/Source/platform/fonts/opentype/OpenTypeCapsSupportTest.cpp:53)
>     OpenTypeCapsSupportTest.LibertineIgnoreMissingTitling
>
(../../third_party/WebKit/Source/platform/fonts/opentype/OpenTypeCapsSupportTest.cpp:38)
>     OpenTypeCapsSupportTest.LibertineSmcpC2scSupported
>
(../../third_party/WebKit/Source/platform/fonts/opentype/OpenTypeCapsSupportTest.cpp:23)
>     OpenTypeCapsSupportTest.LibertineUnicaseFallback
>
(../../third_party/WebKit/Source/platform/fonts/opentype/OpenTypeCapsSupportTest.cpp:98)
>     OpenTypeCapsSupportTest.MEgalopolisSmallCapsSynthetic
>
(../../third_party/WebKit/Source/platform/fonts/opentype/OpenTypeCapsSupportTest.cpp:68)
>     OpenTypeCapsSupportTest.MEgalopolisUnicaseSynthetic
>
(../../third_party/WebKit/Source/platform/fonts/opentype/OpenTypeCapsSupportTest.cpp:83)
> .

Actually, this broke blink_platform_unittests, not the layout tests:

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux/builds/6...

That said, I don't know how/why this got past the CQ but failed on the bot ...

[drott, 2016-04-14 05:53:58]

On 2016/04/13 at 22:17:58, dpranke wrote:
> On 2016/04/13 22:14:32, rjkroege wrote:
> > A revert of this CL (patchset #3 id:40001) has been created in
> > https://codereview.chromium.org/1891613002/ by mailto:rjkroege@chromium.org.
> > 
> > The reason for reverting is: breaks layout tests on Linux
> > 
> > 6 tests crashed:
> >     OpenTypeCapsSupportTest.LibertineAllPetiteSynthesis
> >
(../../third_party/WebKit/Source/platform/fonts/opentype/OpenTypeCapsSupportTest.cpp:53)
> >     OpenTypeCapsSupportTest.LibertineIgnoreMissingTitling
> >
(../../third_party/WebKit/Source/platform/fonts/opentype/OpenTypeCapsSupportTest.cpp:38)
> >     OpenTypeCapsSupportTest.LibertineSmcpC2scSupported
> >
(../../third_party/WebKit/Source/platform/fonts/opentype/OpenTypeCapsSupportTest.cpp:23)
> >     OpenTypeCapsSupportTest.LibertineUnicaseFallback
> >
(../../third_party/WebKit/Source/platform/fonts/opentype/OpenTypeCapsSupportTest.cpp:98)
> >     OpenTypeCapsSupportTest.MEgalopolisSmallCapsSynthetic
> >
(../../third_party/WebKit/Source/platform/fonts/opentype/OpenTypeCapsSupportTest.cpp:68)
> >     OpenTypeCapsSupportTest.MEgalopolisUnicaseSynthetic
> >
(../../third_party/WebKit/Source/platform/fonts/opentype/OpenTypeCapsSupportTest.cpp:83)
> > .
> 
> Actually, this broke blink_platform_unittests, not the layout tests:
> 
>
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux/builds/6...
> 
> That said, I don't know how/why this got past the CQ but failed on the bot ...

This looks like the exactly same failure that I initially encountered on the
ASAN bots, which was missing font files in the isolate step. I am going to split
out landing the tests into a separate CL to make it easier to analyse this
issue, without reverting the whole CL. I intend to make progress on landing the
two subsequent CLs and investigate this test case issue separately.