commit | 1942fd8a7fe9fc609f51ef1fbff210ba5f356415 | [log] [tgz] |
---|---|---|
author | Bruce Dawson <brucedawson@chromium.org> | Mon Nov 20 23:33:47 2017 |
committer | Commit Bot <commit-bot@chromium.org> | Mon Nov 20 23:33:47 2017 |
tree | c378ec5b44031673f42e58e212c06704c7723c36 | |
parent | 8af6692a4f096f285833c5d5d365dd44b61f6b6e [diff] |
Disable incremental linking for some tools We occasionally get build crashes because binaries (usually protoc.exe, but others as well) are generated incorrectly. The symptom is that the incremental linking thunks contain all zeroes instead of a branch instruction, leading to crashes, usually access violations. This is presumed to be a bug in the MSVC++ incremental linker. This turns off incremental linking for four of the binaries that hit this issue most frequently, and some of their neighbors. These binaries are all small enough that incremental linking is not important so there is no real downside to making this change. Testing over the weekend shows that this error, or something very like it, can happen even with incremental linking disabled. I hope that this will reduce the frequency of the failures and there is no downside so I'm going to proceed and see if it helps. Bug: 644525 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I0a9b33b0ad8335868e8e6f227f9a21e5ddeff6e4 Reviewed-on: https://chromium-review.googlesource.com/777764 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#517990}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .