Restrict kDisableSpdy pref to only disable SPDY/3.1, not HTTP/2.

Restrict kDisableSpdy pref to only disable SPDY/3.1, not HTTP/2.

HTTP/2 is now published and officially supported by many browsers and
server. No need to disable it with SPDY/3.1.

BUG=585614
Committed: https://crrev.com/ea2b6531d5976cb7b6b9593a8c8e773e41eaf92d
Cr-Commit-Position: refs/heads/master@{#395612}

[maksims (do not use this acc), 2016-05-06 11:46:57]

Description was changed from

==========
Restrict kDisableSpdy pref to only disable SPDY/3.1, not HTTP/2.

HTTP/2 is now published and officially supported by many browsers and
server. No need to disable it with SPDY/3.1.

BUG=585614
==========

to

==========
Restrict kDisableSpdy pref to only disable SPDY/3.1, not HTTP/2.

HTTP/2 is now published and officially supported by many browsers and
server. No need to disable it with SPDY/3.1.

BUG=585614
==========

[maksims (do not use this acc), 2016-05-06 11:46:57]

maksim.sisov@intel.com changed reviewers:
+ mmenke@chromium.org

[maksims (do not use this acc), 2016-05-06 11:47:11]

please take a look

[mmenke, 2016-05-06 11:54:18]

mmenke@chromium.org changed reviewers:
+ bnc@chromium.org, rch@chromium.org

[mmenke, 2016-05-06 11:54:18]

[+bnc, +rch]:  Do we even still support SPDY?

Not sure if we still want to continue to keep the policy to disable HTTP2 for
enterprises with broken SSL MITM proxies or not.

[mmenke, 2016-05-06 15:10:49]

On 2016/05/06 11:54:18, mmenke wrote:
> [+bnc, +rch]:  Do we even still support SPDY?
> 
> Not sure if we still want to continue to keep the policy to disable HTTP2 for
> enterprises with broken SSL MITM proxies or not.

Glanced at the bug, and it does indicate this is what is intended.  Want
confirmation from people who know SPDY/H2 better that we shouldn't just be
removing enable_spdy31 entirely (And maybe enable_http2 as well).

[Bence, 2016-05-06 15:28:52]

As much as I am in favor of this change, unfortunately we need approval from
enterprise team.  I'm very sorry but this is not LGTM for the time being.

[maksims (do not use this acc), 2016-05-11 05:17:51]

maksim.sisov@intel.com changed reviewers:
+ cbentzel@chromium.org, saswat@chromium.org, sidv@chromium.org

[maksims (do not use this acc), 2016-05-11 05:18:04]

gentle ping

[mmenke, 2016-05-11 14:32:07]

On 2016/05/11 05:18:04, maksims wrote:
> gentle ping

Bence talked to the enterprise leads, and I think he got the approvals, though
he's still out of office, so not sure when he'll be able to sign off on this.

[Bence, 2016-05-11 19:47:05]

On 2016/05/11 05:18:04, maksims wrote:
> gentle ping

Still not LGTM: enterprise leads requested that this change does not land until
53.  Please feel free to ping me again after branch day.  Thank you.

[mmenke, 2016-05-11 19:56:07]

On 2016/05/11 19:47:05, Bence OOO until May 23 wrote:
> On 2016/05/11 05:18:04, maksims wrote:
> > gentle ping
> 
> Still not LGTM: enterprise leads requested that this change does not land
until
> 53.  Please feel free to ping me again after branch day.  Thank you.

And, for the record, branch point is next Thursday, the 19th.

[Bence, 2016-05-22 16:19:49]

LGTM

[maksims (do not use this acc), 2016-05-22 19:04:46]

The CQ bit was checked by maksim.sisov@intel.com

[commit-bot: I haz the power, 2016-05-22 19:04:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1956573004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1956573004/1

[commit-bot: I haz the power, 2016-05-22 19:14:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-22 19:14:07]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[maksims (do not use this acc), 2016-05-23 05:10:01]

The CQ bit was checked by maksim.sisov@intel.com

[maksims (do not use this acc), 2016-05-23 05:10:01]

The patchset sent to the CQ was uploaded after l-g-t-m from bnc@chromium.org
Link to the patchset: https://codereview.chromium.org/1956573004/#ps20001
(title: "rebasing")

[commit-bot: I haz the power, 2016-05-23 05:10:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1956573004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1956573004/20001

[commit-bot: I haz the power, 2016-05-23 05:18:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-23 05:19:00]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[maksims (do not use this acc), 2016-05-23 05:35:28]

Seems like we are missing lgtm from the owner of the file.

cbentzel@, mmenke@, Ryan Hamilton, could somebody of you do that?

[Ryan Hamilton, 2016-05-23 15:49:44]

lgtm

[maksims (do not use this acc), 2016-05-24 04:47:37]

The CQ bit was checked by maksim.sisov@intel.com

[commit-bot: I haz the power, 2016-05-24 04:48:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1956573004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1956573004/20001

[commit-bot: I haz the power, 2016-05-24 05:13:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-24 05:13:31]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Bence, 2016-05-24 11:01:27]

I have recently landed https://crrev.com/1892123003, which would cause a merge
conflict with this CL.  You need to rebase, but since the code this CL is
touching moved to
components/network_session_configurator/network_session_configurator{.cc,_unittest.cc},
the easiest way to do so would be to revert your change in
chrome/browser/io_thread{.cc,_unittest.cc}, then rebase your CL on tip of the
tree, then do your changes manually.  Sorry about the hassle.

[maksims (do not use this acc), 2016-05-24 11:07:12]

On 2016/05/24 11:01:27, Bence wrote:
> I have recently landed https://crrev.com/1892123003, which would cause a merge
> conflict with this CL.  You need to rebase, but since the code this CL is
> touching moved to
>
components/network_session_configurator/network_session_configurator{.cc,_unittest.cc},
> the easiest way to do so would be to revert your change in
> chrome/browser/io_thread{.cc,_unittest.cc}, then rebase your CL on tip of the
> tree, then do your changes manually.  Sorry about the hassle.

Ok, thanks!

[maksims (do not use this acc), 2016-05-24 16:01:01]

The CQ bit was checked by maksim.sisov@intel.com

[maksims (do not use this acc), 2016-05-24 16:01:01]

The patchset sent to the CQ was uploaded after l-g-t-m from bnc@chromium.org,
rch@chromium.org
Link to the patchset: https://codereview.chromium.org/1956573004/#ps60001
(title: "the same thing but in different files")

[commit-bot: I haz the power, 2016-05-24 16:01:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1956573004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1956573004/60001

[commit-bot: I haz the power, 2016-05-24 16:34:18]

Description was changed from

==========
Restrict kDisableSpdy pref to only disable SPDY/3.1, not HTTP/2.

HTTP/2 is now published and officially supported by many browsers and
server. No need to disable it with SPDY/3.1.

BUG=585614
==========

to

==========
Restrict kDisableSpdy pref to only disable SPDY/3.1, not HTTP/2.

HTTP/2 is now published and officially supported by many browsers and
server. No need to disable it with SPDY/3.1.

BUG=585614
==========

[commit-bot: I haz the power, 2016-05-24 16:34:19]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-05-24 16:35:53]

Description was changed from

==========
Restrict kDisableSpdy pref to only disable SPDY/3.1, not HTTP/2.

HTTP/2 is now published and officially supported by many browsers and
server. No need to disable it with SPDY/3.1.

BUG=585614
==========

to

==========
Restrict kDisableSpdy pref to only disable SPDY/3.1, not HTTP/2.

HTTP/2 is now published and officially supported by many browsers and
server. No need to disable it with SPDY/3.1.

BUG=585614

Committed: https://crrev.com/ea2b6531d5976cb7b6b9593a8c8e773e41eaf92d
Cr-Commit-Position: refs/heads/master@{#395612}
==========

[commit-bot: I haz the power, 2016-05-24 16:35:55]

Patchset 4 (id:??) landed as
https://crrev.com/ea2b6531d5976cb7b6b9593a8c8e773e41eaf92d
Cr-Commit-Position: refs/heads/master@{#395612}