Google Git
Sign in
chromium / chromium / src / 9baef62d11e7576bad5e6264568e3c91d5bda764
commit9baef62d11e7576bad5e6264568e3c91d5bda764[log] [tgz]
authormsw@chromium.org <msw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>Tue May 14 05:30:46 2013
committermsw@chromium.org <msw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>Tue May 14 05:30:46 2013
treed0cea19a1e88686f5fed75ed7e3a556e523a9d17
parentfb1aac14e2833d6ba5b9d9ba61a964a6eb26f180 [diff]
Fix LabelButton preferred size calculations.

Label font/size changes in GetPreferredSize were causing infinite loops.
( the new-dialog-style edit bookmark dialog would crash on launch )
Rewrite the sizing code using a local Label object, fix for correctness too.
Remove a redundant call to SetAccessibleName.

BUG=155363
TEST=Button sizing is correct, no crashes on new-style edit bookmark dialog.
R=sky@chromium.org

Review URL: https://chromiumcodereview.appspot.com/15070004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@199921 0039d316-1c4b-4281-b951-d872f2087c98
1 file changed
tree: d0cea19a1e88686f5fed75ed7e3a556e523a9d17
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. breakpad/
  6. build/
  7. cc/
  8. chrome/
  9. chrome_frame/
  10. chromeos/
  11. cloud_print/
  12. components/
  13. content/
  14. courgette/
  15. crypto/
  16. dbus/
  17. device/
  18. extensions/
  19. google_apis/
  20. google_update/
  21. gpu/
  22. ipc/
  23. jingle/
  24. media/
  25. native_client_sdk/
  26. net/
  27. ppapi/
  28. printing/
  29. remoting/
  30. rlz/
  31. sandbox/
  32. sdch/
  33. skia/
  34. sql/
  35. sync/
  36. testing/
  37. third_party/
  38. tools/
  39. ui/
  40. url/
  41. webkit/
  42. win8/
  43. .DEPS.git
  44. .gitignore
  45. .gitmodules
  46. Android.mk
  47. AUTHORS
  48. codereview.settings
  49. DEPS
  50. LICENSE
  51. LICENSE.chromium_os
  52. OWNERS
  53. PRESUBMIT.py
  54. PRESUBMIT_test.py
  55. WATCHLISTS