| commit | 19e2218a58c03100613c886e579d3c4ef94dcfa2 | [log] [tgz] |
|---|---|---|
| author | Greg Guterman <guterman@google.com> | Sat Nov 07 00:50:30 2020 |
| committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Sat Nov 07 00:50:30 2020 |
| tree | 8a66beeaa76f87a1e7a7b37b0da228f71c779b6b | |
| parent | 5bef4b10b699e5a962b4c5176f93822124104646 [diff] |
Enable analyze DEPS autorolls opt in for trybots. This ends the correctness checking period for the Analyze DEPS rolls. After gathering data for 3 weeks, we've encountered 94 failed builds with suites where the new analyze logic would've run the failing suites. There were 26 suites where it wouldn't have run the failed suites, but 24 of them passed on retry, indicating a flaky failure and exonerating the Analyze DEPS rolls logic. The two remaining misses were not retried and could not be ruled out. Deeper investigation could find out one way or the other, but the success rate is high enough that I feel it's safe enough. If any DEP ends up falsely passing, the culprit files, or the entire DEP subdirectory can be placed in src.git/trybot_analyze_config.json Bug: 923016 Change-Id: I2eff70e373ee35e708548cf343183603b149f0fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/build/+/2522453 Commit-Queue: Gregory Guterman <guterman@google.com> Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
If you're here to make a change to ‘recipes’ (the code located in scripts/slave/recipes*), please take a look at the README for more information pertaining to recipes.
The preferred style is PEP8 with two-space indent; that is, the Chromium Python style. Functions use lowercase_with_underscores, with the exception of the special functions RunSteps and RunTests in recipes. Use yapf (git cl format --no-clang-format) to autoformat new code.