commit | 19f3802a491531f9d22a92a338b4905fa60afdb4 | [log] [tgz] |
---|---|---|
author | Derek Cheng <imcheng@chromium.org> | Mon Aug 13 18:28:47 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Mon Aug 13 18:28:47 2018 |
tree | d285316fcb2e94da82f4709385b4016c1eefebe7 | |
parent | 7b1912e168fdd16c973332d7e59ce3fc784423fb [diff] |
[Cast channel] No JSON parsing in KeepAliveDelegate. Due to the way cast message delegates are layered, a cast message coming from a receiver first goes through KeepAliveDelegate, which inspects the message for keep-alive type and passes it through if it is not a ping/pong message. Instead of doing JSON parsing (which isn't safe in browser process), we will check for the heartbeat namespace and do a quick substring check for PING/PONG type. Also removed the now unused function and clean up tests to move usage of JSONReader to the test itself. Change-Id: I3c906b8215f7b7149b18c014278cdad3bdf6b3e7 Bug: 809249 Reviewed-on: https://chromium-review.googlesource.com/1170130 Commit-Queue: Derek Cheng <imcheng@chromium.org> Reviewed-by: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#582647}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .