commit | 1abf6643628c17a905420f9366adf04a84f3ebf6 | [log] [tgz] |
---|---|---|
author | Martin Kreichgauer <martinkr@google.com> | Thu Aug 30 14:55:29 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Thu Aug 30 14:55:29 2018 |
tree | 3b73e5d9e010ee5ba0377b52de4e250d8b2f0191 | |
parent | f35716acc47c474ef6d291c14d1bb113c2be8b5d [diff] |
webauthn: prevent UI from dispatching to the same authenticator multiple times Using the transport switch drop-down menu, it is possible to cycle away from and then back to the Touch ID sheet, which currently causes the request to be dispatched onto the TouchIdAuthenticator each time the sheet is shown. This sort of works in the production build (it restarts the request, which will make the Touch ID dialog disappear and then reappear). In debug, however, it crashes on a DCHECK. We haven't defined whether a FidoAuthenticator should be able to handle multiple invocations of MakeCredential/GetAssertion over the lifetime of the instance. Hence, the UI should stop doing this. Bug: 678128,847985 Change-Id: Id008de98bc8aa6477e9863ca2e22cd136316b423 Reviewed-on: https://chromium-review.googlesource.com/1196427 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#587575}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .