commit | 1b1bd2a01611eb215e3eda29499131262f45ea66 | [log] [tgz] |
---|---|---|
author | Yutaka Hirano <yhirano@chromium.org> | Wed Jul 11 17:37:26 2018 |
committer | Ben Mason <benmason@chromium.org> | Wed Jul 11 17:37:26 2018 |
tree | 43b4ebc4541d09e71d7af61746081e5e92288a61 | |
parent | bdc71e75ce948ad15202d631f1b9a59f5cc3167e [diff] |
Revert "[Fetch] Use wrapper tracing to express references between wrappers" This reverts commit 8057f58cb22579bc685efa50c579325ed047d51a. Reason for revert: Crashing. See https://crbug.com/862440. Original change's description: > [Fetch] Use wrapper tracing to express references between wrappers > > BodyStreamBuffer has a ReadableStream instance, but because it's > implemented in V8Extra we cannot holds it as a member (i.e., as a > ScriptValue). Instead, we attach the value to the JS wrapper of the > C++ object. This required us to maintain chains of wrappers, > FetchEvent -> Request -> BodyStreamBuffer for example, manually. > > This CL replaces that mechanism with wrapper tracing. > > Bug: None > Change-Id: I889ef0d0442d62ad50826a4b487ec234f041a982 > Reviewed-on: https://chromium-review.googlesource.com/1124270 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Adam Rice <ricea@chromium.org> > Reviewed-by: Matt Falkenhagen <falken@chromium.org> > Reviewed-by: Yuki Shiino <yukishiino@chromium.org> > Commit-Queue: Yutaka Hirano <yhirano@chromium.org> > Cr-Commit-Position: refs/heads/master@{#573533} TBR=falken@chromium.org,ricea@chromium.org,yukishiino@chromium.org,yhirano@chromium.org,haraken@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 862440 Change-Id: I4c1bd85ff5f4b078b4c0c56474e279fe83fc5eaa Reviewed-on: https://chromium-review.googlesource.com/1132634 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#574065}(cherry picked from commit 7a0a490dd3d9d640e088aee823bd069c74a8ef64) Reviewed-on: https://chromium-review.googlesource.com/1133341 Reviewed-by: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/branch-heads/3488@{#3} Cr-Branched-From: 426a53b7a3cf88a3c24a61d14346a6815ee2b2d4-refs/heads/master@{#574034}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .