commit | 1b2f95835607dbb9c6021df8893fb18f4c7aee9e | [log] [tgz] |
---|---|---|
author | Yuki Yamada <yukiy@google.com> | Fri Oct 05 09:20:48 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Fri Oct 05 09:20:48 2018 |
tree | e8c48d9a129dc7ec47b24106e13bb94fe20362d7 | |
parent | 2555486fd96872f6b98f9ad54c541d7ee2b6fcb1 [diff] |
Create new EventHandler and base class for EventListener/EventHandler This CL implements these classes in Blink: JSBasedEventListener (The base class for | EventLisntener/EventHandler) +- JSEventListener (Implements EventListener) +- JSEventHandler (Implements EventHandler and | other special types) +- JSEventHandlerForContentAttribute (Supports lazy compilation for content attribute) EventHandlers start to support incumbent realm using blink::V8EventHandlerNonNull that inherits blink::CallbackFunctionBase. (EventListener already supports incumbent realm.) These four classes are no longer referenced from anywhere: blink::V8AbstractEventListener blink::V8EventListenerOrEventHandler blink::V8ErrorHandler blink::V8LazyEventListener Although these are no longer necessary, this CL does not remove them so that we can easily switch which classes to use in case new classes contains some problems. regarding crbug.com/759461 : OnErrorEventHandler for content attribute, which has different number of arguments, gets supported by blink::JSEventHandler and blink::JSEventHandlerForContentAttribute. regarding crbug.com/664676 : |js_event| in the relevant realm of |event|'s target is created in blink::JSBasedEventListener::handleEvent(). Bug: 872138, 849236, 759461, 664676, 606900 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I356734fc16611277ad9f3f279a676e7dc8083408 Reviewed-on: https://chromium-review.googlesource.com/c/1215512 Commit-Queue: Yuki Yamada <yukiy@google.com> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Hayato Ito <hayato@chromium.org> Reviewed-by: Hitoshi Yoshida <peria@chromium.org> Reviewed-by: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#597054}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .