commit | 1b593cecee7debb97c6993d96e364000695f63aa | [log] [tgz] |
---|---|---|
author | Takuto Ikuta <tikuta@chromium.org> | Wed Mar 31 03:52:42 2021 |
committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Mar 31 03:52:42 2021 |
tree | ce7c36c892b0d31c5a825f1fbffb137f12208660 | |
parent | 98e7ea96a5a5b15ae54a891a4c8a34edb3aefc08 [diff] |
tricium: run `go generate` Fixed to use ShouldResembleProto in some tests. Fixed to use proto.Clone in go/src/infra/tricium/appengine/backend/rpc_worker_done.go for `go vet` warning. Bug: 1146109 Change-Id: Idea718195b62fc0f9698bd1a6c5fc14b65e5226e Reviewed-on: https://chromium-review.googlesource.com/c/infra/infra/+/2793866 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Cr-Commit-Position: refs/heads/master@{#39800}
Testing Welcome to the Chrome Infra repository!
Wondering where to start? Check out General Chrome Infrastructure documentation. In particular, to check out this repo and the rest of the infrastructure code, follow the instructions here. The rest of this page is specific to this repo.
sys.path
modifications.from infra.path_hacks.common import <stg>
is actually getting <stg>
from build/scripts/common.git push origin <updated hash>:deployed
git push
commandIf you've added a new module, run your tests with test.py:
*_test.py
files to this directory.Double-check that your tests are getting picked up when you want them to be: ./test.py test <path-to-package>
.
Tests still not getting picked up by test.py? Double-check to make sure you have __init__.py
files in each directory of your module so Python recognizes it as a package.
The preferred style is PEP8 with two-space indent; that is, the Chromium Python style, except functions use lowercase_with_underscores
. Use yapf (git cl format
) to autoformat new code.