| commit | 1b98245e3cb73fd67d1e2e50a016f4d2af76dd30 | [log] [tgz] |
|---|---|---|
| author | Dirk Pranke <dpranke@chromium.org> | Fri Nov 30 02:06:49 2018 |
| committer | Commit Bot <commit-bot@chromium.org> | Fri Nov 30 02:42:29 2018 |
| tree | d13b861f51c68b1a9ea07def2dc6921e11eea645 | |
| parent | 63d69d7792c1ef8f18d8b620ff025de767849514 [diff] |
Move typ's expectation-processing code into expectations_parser.py. Prior to this CL, the logic for handling test expectations in typ was mostly split between runner.py and expectations_parser.py. runner.py was a fine location for actually loading the file contents, but most of the logic of actually parsing and handling the expectations isn't all that germane to running the tests, so it was bloating the code. Plus, having a file dedicated only to parsing the tagged test list format was a bit excessive. So, this CL moves the logic for figuring out the expected results for a given test into expectations_parser.py and renames some of the classes a bit to be more generic. This simplifies runner.py a bit and complicates expectations_parser.py, but that's probably the right tradeoff. It also makes expectations_parser.py a less-accurate name for the file. It should probably be renamed to expectations.py, but I avoid doing that in this CL to minimize the size of the diff to review. Bug: chromium:835690 Change-Id: I4c8cc16547489c409d9cab6fa7b10910582ad83e Reviewed-on: https://chromium-review.googlesource.com/c/1352282 Commit-Queue: Dirk Pranke <dpranke@chromium.org> Reviewed-by: Ned Nguyen <nednguyen@google.com>
Catapult is the home for several performance tools that span from gathering, displaying and analyzing performance data. This includes:
These tools were created by Chromium developers for performance analysis, testing, and monitoring of Chrome, but they can also be used for analyzing and monitoring websites, and eventually Android apps.
Please see our contributor's guide