commit | 1ba104fbd5e9af68817fbcc88e2a76b654eaaf39 | [log] [tgz] |
---|---|---|
author | Bruce Dawson <brucedawson@chromium.org> | Thu Dec 28 23:56:13 2017 |
committer | Commit Bot <commit-bot@chromium.org> | Thu Dec 28 23:56:28 2017 |
tree | 731caa0b73326ad85368686a8183362c50437efe | |
parent | f671d5a01135eb084bbec171d536cb5d1248e124 [diff] |
Revert "[LayoutNG] Pass Container() to NGOutOfFlowLayout instead of ContainerBlock()" This reverts commit 2b38ceb8d26dfd7cd2607935e88ef31a81c38f78. Reason for revert: Suspected of causing 176 unexpected failures such as: http/tests/navigation/timerredirect-frames.html failed unexpectedly (text diff) Original change's description: > [LayoutNG] Pass Container() to NGOutOfFlowLayout instead of ContainerBlock() > > Fixes external/wpt/css/css-position/position-relative-* DCHECK crashes > > Had to modify NGOutOfFlowLayoutPart constructor. > > It used to take NGBlockNode to compute scrollbar sizes, > contains_absolute, and contains_fixed. > > Containing block can be arbitrary LayoutBoxModelObject with inline blocks. > None of NG*Nodes can be constructed from LayoutBoxModelObject. > => NGOutOfFlowLayoutPart constructor cannot take NG*Node, but must take > all required LayoutObject properties instead. > > Bug: 740993 > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng > Change-Id: I731800feddf5d53a9104f62d9d616f56a6195671 > Reviewed-on: https://chromium-review.googlesource.com/845499 > Commit-Queue: Aleks Totic <atotic@chromium.org> > Reviewed-by: Koji Ishii <kojii@chromium.org> > Cr-Commit-Position: refs/heads/master@{#526328} TBR=kojii@chromium.org,atotic@chromium.org Change-Id: Ifb9e4eb8efd5207fc5ea2d4dd2d31381eda64e6e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 740993 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Reviewed-on: https://chromium-review.googlesource.com/846242 Reviewed-by: Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#526338}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .