| commit | 1be865f6b9edf39aaeba57750b33abc305f8ae0e | [log] [tgz] |
|---|---|---|
| author | thakis <thakis@chromium.org> | Wed Dec 09 15:27:27 2015 |
| committer | Commit bot <commit-bot@chromium.org> | Wed Dec 09 15:32:25 2015 |
| tree | 7fcea67fad0db02e70dd4617b493f6a413bd6f92 | |
| parent | f8f64423ed965a85cda6d4855757ca0394746fec [diff] |
Revert of Enable Control Flow Integrity for the official Linux Chrome. (patchset #1 id:1 of https://codereview.chromium.org/1502233004/ ) Reason for revert: Broken at clang trunk (http://crbug.com/568121) Original issue's description: > Enable Control Flow Integrity for the official Linux Chrome. > > This CL turns on CFI, a security check: > https://sites.google.com/a/chromium.org/dev/developers/testing/control-flow-integrity > http://clang.llvm.org/docs/ControlFlowIntegrity.html > > This feature enables LTO (Link-Time Optimization) builds, which slow down the linker by 3x-4x. > CFI also comes with a code size overhead of about 7%-9%. The runtime CPU cost is less than 1%, > and should not be an issue. > > BUG=chromium:464797 > Intent to Implement thread: > https://groups.google.com/a/chromium.org/d/msg/chromium-dev/pbJqt6ccMII/7iJC2oklCAAJ > > This is a fourth attempt to land the CL. Previous attempts: > https://codereview.chromium.org/1502373003/ > https://codereview.chromium.org/1501593003/ > https://codereview.chromium.org/1393283005/ > > The last time it failed, it was https://crbug.com/567637 > (mismatched deps expectations for the installer). > Fixing the expectations. > > Committed: https://crrev.com/64719eadd90a3131a744baa89a1183bdcb1e2375 > Cr-Commit-Position: refs/heads/master@{#363895} TBR=thestig@chromium.org,krasin@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:464797 Review URL: https://codereview.chromium.org/1517443002 Cr-Commit-Position: refs/heads/master@{#364068}