commit | 1c21bc5a4c200a0f6acf959baa6c4cd8f61a5172 | [log] [tgz] |
---|---|---|
author | Maxim Kolosovskiy <kolos@chromium.org> | Tue Nov 20 13:08:47 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Tue Nov 20 13:08:47 2018 |
tree | 15f1b479d76b7e5487e196a7f54fb81e4d57b7c6 | |
parent | 95f6363a1d4fd53b39aa00ef02bc70a1df318bca [diff] |
Revert "v8binding: Do not hold a cross origin ScriptState in IDL callback function" This reverts commit 756bea38c853ce40e3daba7f7fadf85b0920785f. Reason for revert: FindIt suspects that this is the culprit for a number of failures https://findit-for-me.appspot.com/waterfall/failure?url=https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty%20ASAN/builds/18261 Original change's description: > v8binding: Do not hold a cross origin ScriptState in IDL callback function > > Make IDL callback function not hold a ScriptState of its > creation context when it's cross origin from the incumbent > realm. > > Not holding a cross origin ScriptState, there is much > less risk to access a cross origin context. > > IDL callback interface will follow the same approach in > a separate patch. > > Bug: 892755, 886588, 904218 > Change-Id: Ie55b436fcc5f66f4ee053ef08ad98ea68fb3a2d6 > Reviewed-on: https://chromium-review.googlesource.com/c/1314023 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Hitoshi Yoshida <peria@chromium.org> > Commit-Queue: Yuki Shiino <yukishiino@chromium.org> > Cr-Commit-Position: refs/heads/master@{#609662} TBR=peria@chromium.org,yukishiino@chromium.org,haraken@chromium.org Change-Id: Ic0e5a3006a43f8a95202ac1d890f365307068877 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 892755, 886588, 904218 Reviewed-on: https://chromium-review.googlesource.com/c/1343093 Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#609678}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .