commit | 1cf15c7f5ed50ba69cba650092a73d619199f9a7 | [log] [tgz] |
---|---|---|
author | Rakina Zata Amni <rakina@chromium.org> | Mon Feb 04 08:07:15 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Mon Feb 04 08:07:15 2019 |
tree | d48f6f360a8621f8fa96e33fb5022ba1ab8661b1 | |
parent | c6bb24c14f1b19f356f75ea8a30a24cbd0a41ae1 [diff] |
Make FindStringBetweenPositions use FindBuffer and activate invisible matches Previously FindStringBetweenPositions uses TextIterator which doesn't support matching of invisible nodes. This function is used by find-next but not counting total FIP matches, which uses FindBuffer already. Thus, the total count of FIP matches is correct (counting invisible nodes), but when we try to navigate to the match through find-next/prev it will skip those matches. This CL modifies FindStringBetweenPositions to use FindBuffer that now supports finding a match within a range. This CL also dispatches the "activateinvisible" event to active matches that are invisible when navigated-to through find-next/prev, because otherwise it couldn't highlight the range even when it has the range. Bug: 868227, 873057 Change-Id: Ib9475318bcb38ec1d97e3b029a7eb25495aed060 Reviewed-on: https://chromium-review.googlesource.com/c/1451697 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#628683}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .