commit | 1cfb1ad672060b5b8d254ea4d8da0edc5856cbb9 | [log] [tgz] |
---|---|---|
author | Jared Loucks <jaredloucks@google.com> | Mon Mar 22 16:21:44 2021 |
committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Mar 22 16:21:44 2021 |
tree | 894297b3414fff6bd754ab06bafe85969ba81eed | |
parent | 9ff132717bbb7a0157a67f54a35accab6333fa88 [diff] |
crosfleet: second refactor of dut info printout Rather than formatting the JSON output by hand, which is brittle and hard to read, I added a new proto package that we can use to model what we want to print out and then offload JSON formatting onto the protojson library. Bug: b:182474502 Change-Id: I0cdc6134ce96033d38e086aaa787f6f9efa9b0d7 Reviewed-on: https://chromium-review.googlesource.com/c/infra/infra/+/2773443 Reviewed-by: Taylor Clark <taylormade@google.com> Commit-Queue: Jared Loucks <jaredloucks@google.com> Cr-Commit-Position: refs/heads/master@{#39586}
Testing Welcome to the Chrome Infra repository!
Wondering where to start? Check out General Chrome Infrastructure documentation. In particular, to check out this repo and the rest of the infrastructure code, follow the instructions here. The rest of this page is specific to this repo.
sys.path
modifications.from infra.path_hacks.common import <stg>
is actually getting <stg>
from build/scripts/common.git push origin <updated hash>:deployed
git push
commandIf you've added a new module, run your tests with test.py:
*_test.py
files to this directory.Double-check that your tests are getting picked up when you want them to be: ./test.py test <path-to-package>
.
Tests still not getting picked up by test.py? Double-check to make sure you have __init__.py
files in each directory of your module so Python recognizes it as a package.
The preferred style is PEP8 with two-space indent; that is, the Chromium Python style, except functions use lowercase_with_underscores
. Use yapf (git cl format
) to autoformat new code.