commit | 1d3752206b8009e6940faaaf733c53640cce5af2 | [log] [tgz] |
---|---|---|
author | Joanna Wang <jojwang@google.com> | Sat Jan 09 00:08:38 2021 |
committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Sat Jan 09 00:08:38 2021 |
tree | 0d0cddf22302d59d40b54b4afa26a33a3b76379b | |
parent | 09209b1ca6004121bc7e48d97c17efc10d2f7d9e [diff] |
[Monorail]Add AttachmentUpload to v3.ModifyIssues. - Also replace all work_env.AttachmentUpload with framework_helpers.AttachmentUpload Bug: monorail:8019 Change-Id: I2a300087e3ebb325c3c88537d5dd8daff7a08f70 Reviewed-on: https://chromium-review.googlesource.com/c/infra/infra/+/2601272 Reviewed-by: Andrew Chang <andrewjc@google.com> Commit-Queue: Joanna Wang <jojwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#37441}
Testing Welcome to the Chrome Infra repository!
Wondering where to start? Check out General Chrome Infrastructure documentation. In particular, to check out this repo and the rest of the infrastructure code, follow the instructions here. The rest of this page is specific to this repo.
sys.path
modifications.from infra.path_hacks.common import <stg>
is actually getting <stg>
from build/scripts/common.git push origin <updated hash>:deployed
git push
commandIf you've added a new module, run your tests with test.py:
*_test.py
files to this directory.Double-check that your tests are getting picked up when you want them to be: ./test.py test <path-to-package>
.
Tests still not getting picked up by test.py? Double-check to make sure you have __init__.py
files in each directory of your module so Python recognizes it as a package.
The preferred style is PEP8 with two-space indent; that is, the Chromium Python style, except functions use lowercase_with_underscores
. Use yapf (git cl format
) to autoformat new code.