commit | 1dcd6759161d5b2b897c49d42978f9e8c301eb31 | [log] [tgz] |
---|---|---|
author | Victor Costan <pwnall@chromium.org> | Fri Mar 16 12:31:36 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Fri Mar 16 12:31:36 2018 |
tree | 89d649cf603463fb20c6d560591dac222df6f9f2 | |
parent | 07ef4996a501f1a447e9e605d927452e9f273d44 [diff] |
Cookie Store: Enable some change tests for CookieStoreIOS. The iOS CookieStore implementations synchronize (to some degree) a CookieMonster with the system cookie store. Change detection is implemented by storing a snapshot of the system cookie store's last seen contents, and computing diffs between the current system store contents and the snapshot. This implementation has two major differences from the CookieMonsterChangeDispatcher implementation: 1) The ordering of changes observed between two snapshots cannot be known. However, the CookieStore tests expect changes to be observed in the exact order in which the corresponding commands were issued. 2) The current diffing implementation does not distinguish between deletion causes. The tests rely on a distinction between OVERWRITE and EXPLICIT. This CL introduces CookieStoreTestTraits members that account for the differences above, making it possible to run the change tests against the CookieStoreIOS implementation. CookieStoreIOSPersistent requires significant changes to pass the tests, so it will be addressed in a separate CL. Bug: 729800, 813931 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ib959c4a2d05ef84ab154290ee91f975436a7ee64 Reviewed-on: https://chromium-review.googlesource.com/947844 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by: Matt Menke <mmenke@chromium.org> Reviewed-by: Richard Coles <torne@chromium.org> Reviewed-by: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#543673}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .