Google Git
Sign in
chromium / infra / infra / 1ddc460e3141d05e108673abe3cd06fe572c880b
commit1ddc460e3141d05e108673abe3cd06fe572c880b[log] [tgz]
authorTakuto Ikuta <tikuta@chromium.org>Wed Mar 17 02:49:42 2021
committerLUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Mar 17 02:49:42 2021
treed86ca82b72a0e232df76b6b6f6fde3e9e1cd7c63
parenteaaf87dfecbbc3b6f4eff6bfae3dbb8c511f122d [diff]
Revert "cas: disable cross build for some architectures temporary"

This reverts commit 6a55011a2d38cdae40da08c9299bb8603f54cfa2.

Reason for revert: 
This is not necessary after https://crrev.com/c/2763967

Original change's description:
> cas: disable cross build for some architectures temporary
>
> This is temporal workaround for build failure in
> https://ci.chromium.org/p/infra/builders/ci/infra-continuous-xenial-64/32238?
>
> I'll send patch to
> https://github.com/dgraph-io/ristretto/blob/e4f298c8aa88bdedc4bd62812721895273abc23c/z/simd/search.go#L1
>
> Bug: 1172879
> Change-Id: Idced586c513934a1833bb22d506d1b15503aaa94
> Reviewed-on: https://chromium-review.googlesource.com/c/infra/infra/+/2763354
> Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@google.com>
> Reviewed-by: Junji Watanabe <jwata@google.com>
> Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
> Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#39393}

Bug: 1172879
Change-Id: I67f6fa4aa196b8ae610d51d331b1860224805b5f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/infra/infra/+/2763968
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Junji Watanabe <jwata@google.com>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#39434}
1 file changed
tree: d86ca82b72a0e232df76b6b6f6fde3e9e1cd7c63
  1. 3pp/
  2. appengine/
  3. appengine_module/
  4. bootstrap/
  5. build/
  6. chromeperf/
  7. cipd/
  8. crdx/
  9. doc/
  10. docker/
  11. glyco/
  12. go/
  13. infra/
  14. node/
  15. packages/
  16. python_pb2/
  17. recipes/
  18. test/
  19. utils/
  20. .gitattributes
  21. .gitignore
  22. .style.yapf
  23. .yapfignore
  24. codereview.settings
  25. CONTRIBUTING.md
  26. DEPS
  27. LICENSE
  28. navbar.md
  29. OWNERS
  30. PRESUBMIT.py
  31. README.md
  32. run.py
  33. test.py
  34. WATCHLISTS
  35. WHITESPACE
README.md

infra.git repository

Testing Welcome to the Chrome Infra repository!

Wondering where to start? Check out General Chrome Infrastructure documentation. In particular, to check out this repo and the rest of the infrastructure code, follow the instructions here. The rest of this page is specific to this repo.

Entry points

  • run.py: wrapper script to run programs contained in subdirectories without having to deal with sys.path modifications.
  • test.py: multi-purpose script to run tests.
  • packages/infra_libs/: generally useful functions and classes
  • infra/services/: standalone programs intended to be run as daemons.
  • infra/tools: command-line tools, intended to be run by developers.
  • appengine/: many Chrome-infra-managed AppEngine applications.
  • infra/experimental: for, well, experimental stuff. Once they are stabilized and reviewed, they should be moved in a more permanent place.

Miscellaneous technical stuff

  • bootstrap/: utilities to set up a proper Python virtual environment.
  • infra/path_hacks: submodules of this modules give access to modules in the build/ repository. from infra.path_hacks.common import <stg> is actually getting <stg> from build/scripts/common.
  • utils/: purpose? utils?
  • Need to bump infra/deployed to pick up changes?
    • git push origin <updated hash>:deployed
    • mail chrome-troopers@, include:
      • previously deployed hash (for quick rollback)
      • the hash you just pushed
      • the list of CLs that made this push necessary
      • the output of the git push command

Integrating tests with test.py

If you've added a new module, run your tests with test.py:

  1. Create a .coveragerc file in the root directory of the module you want to test. Take a look at another .coveragerc to see what to include in that.
  2. Create a “test” directory in the root directory of the module you want to test. Move your *_test.py files to this directory.

Double-check that your tests are getting picked up when you want them to be: ./test.py test <path-to-package>.

Tests still not getting picked up by test.py? Double-check to make sure you have __init__.py files in each directory of your module so Python recognizes it as a package.

Style

The preferred style is PEP8 with two-space indent; that is, the Chromium Python style, except functions use lowercase_with_underscores. Use yapf (git cl format) to autoformat new code.