commit | 1ec126531ceaebdd0b9ee340ec4d750507290fd7 | [log] [tgz] |
---|---|---|
author | Dan Beam <dbeam@chromium.org> | Fri Dec 07 04:31:18 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Fri Dec 07 04:31:18 2018 |
tree | 93918722d5cf294c9a554b4ac37a52c3475525f4 | |
parent | e324812251510778815829c1b07043b6d53f8414 [diff] |
Downloads: detect failed file icons and show default thumbnail On the downloads page, we consult the system for a themed image for the type of file downloads. Ex: zip files -> archive icon. When a system doesn't know why type of icon to show for a specific file type, it can either return a default or nothing. Right now, Linux returns nothing, so we show nothing. chrome://fileicon tries to warn us by giving a network error (which has been ignored until now). So, when a chrome://fileicon fails to load, show a default filetype icon in respond. Before & after screenshots: https://imgur.com/a/txRbfIG R=dpapad@chromium.org BUG=855259 Change-Id: I370fd8ea119b194ad8e1ba7e0dfad32c6cea1bbe Reviewed-on: https://chromium-review.googlesource.com/c/1132560 Commit-Queue: Dan Beam <dbeam@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#614581}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .