| commit | 1ed0acfc528fb52602d776d22ade9ad50c23f614 | [log] [tgz] |
|---|---|---|
| author | jam <jam@chromium.org> | Thu Sep 25 06:43:32 2014 |
| committer | Commit bot <commit-bot@chromium.org> | Thu Sep 25 06:43:47 2014 |
| tree | ec25eaacf55e9c774c149e201381e40da46a23af | |
| parent | ab32c4d3fbac8f6992863e52c372d0b0be6252d3 [diff] |
Revert of Revert of Add test for ChromeVox keyboard commands. (patchset #1 id:1 of https://codereview.chromium.org/603823002/) Reason for revert: sorry I reverted this incorrectly, the problem was that the isolate needed a nacl file. I'm not sure why it only needed it on debug cros and not release. I landed it in https://codereview.chromium.org/597283004/ Original issue's description: > Revert of Add test for ChromeVox keyboard commands. (patchset #21 id:390004 of https://codereview.chromium.org/490443002/) > > Reason for revert: > flakes, see http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/31850 > > failures: > TestAsNormalAndGuestUser/SpokenFeedbackTest.ChromeVoxPrefixKey/0 > TestAsNormalAndGuestUser/SpokenFeedbackTest.ChromeVoxPrefixKey/1 > TestAsNormalAndGuestUser/SpokenFeedbackTest.ChromeVoxShiftSearch/1 > TestAsNormalAndGuestUser/SpokenFeedbackTest.ChromeVoxShiftSearch/0 > LoggedInSpokenFeedbackTest.AddBookmark > > Original issue's description: > > Add test for ChromeVox keyboard commands. > > > > This is just a couple of quick sanity checks to prevent future regressions > > like the one in the linked bug. It tests both a Search+Shift shortcut and > > the corresponding Prefix Key shortcut. > > > > Adds support for sending the meta modifier key in > > aura/x11 tests. > > > > BUG=404470 > > > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291547 > > > > Committed: https://chromium.googlesource.com/chromium/src/+/8cab2737f1cb6e6011b0946f6bef5027868602c0 > > > > Committed: https://crrev.com/91703961c10dfa0f452999ed7cb87945ea817362 > > Cr-Commit-Position: refs/heads/master@{#293687} > > > > Committed: https://crrev.com/15ea141544fedaf306c94890b5be19b7c5df885a > > Cr-Commit-Position: refs/heads/master@{#296074} > > TBR=dtseng@chromium.org,sky@chromium.org,dmazzoni@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=404470 > > Committed: https://crrev.com/14e5bdf573d0621dfdd553888a5d3c557fb699a0 > Cr-Commit-Position: refs/heads/master@{#296627} TBR=dtseng@chromium.org,sky@chromium.org,dmazzoni@chromium.org NOTREECHECKS=true NOTRY=true BUG=404470 Review URL: https://codereview.chromium.org/600373002 Cr-Commit-Position: refs/heads/master@{#296670}