commit | 1fb046306b9ebe160eeacc7843ee1ddd15a47ffa | [log] [tgz] |
---|---|---|
author | Raul Tambre <raul@tambre.ee> | Mon Apr 08 19:13:37 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Mon Apr 08 19:13:37 2019 |
tree | fd1dd87fa2b12e0347f813a1d4ecdef63d589993 | |
parent | 0b62ed79ed5049332f58c06dbdb8e8bc4105010e [diff] |
Fix UTF-8 output in gclient_utils.CheckCallAndFilter Hooks for Electron output UTF-8 characters. Example error for when "✔" is output: File "/home/markus/depot_tools/metrics.py", line 266, in print_notice_and_exit yield File "/home/markus/depot_tools/gclient.py", line 3112, in <module> sys.exit(main(sys.argv[1:])) File "/home/markus/depot_tools/gclient.py", line 3098, in main return dispatcher.execute(OptionParser(), argv) File "/home/markus/depot_tools/subcommand.py", line 252, in execute return command(parser, args[1:]) File "/home/markus/depot_tools/gclient.py", line 2677, in CMDsync ret = client.RunOnDeps('update', args) File "/home/markus/depot_tools/gclient.py", line 1746, in RunOnDeps self.RunHooksRecursively(self._options, pm) File "/home/markus/depot_tools/gclient.py", line 1052, in RunHooksRecursively hook.run() File "/home/markus/depot_tools/gclient.py", line 245, in run cmd, cwd=self.effective_cwd, always=self._verbose) File "/home/markus/depot_tools/gclient_utils.py", line 344, in CheckCallAndFilterAndHeader return CheckCallAndFilter(args, **kwargs) File "/home/markus/depot_tools/gclient_utils.py", line 576, in CheckCallAndFilter stdout.write(in_byte.decode()) File "/usr/lib/python2.7/encodings/utf_8.py", line 16, in decode return codecs.utf_8_decode(input, errors, True) UnicodeDecodeError: 'utf8' codec can't decode byte 0xe2 in position 0: unexpected end of data This issue was introduced in CL:1524583. Bug: 942522 Change-Id: I3c4355b925b34398c800d142f942531a829e0297 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1541334 Auto-Submit: Raul Tambre <raul@tambre.ee> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Raul Tambre <raul@tambre.ee>
Tools for working with Chromium development. It requires python 2.7.
The most important tools are:
fetch
: A gclient
wrapper to checkout a project. Use fetch --help
for more details.gclient
: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Use gclient help
for more details and README.gclient.md.git cl
: A code review tool to interact with Rietveld or Gerrit. Use git cl help
for more details and README.git-cl.md.roll-dep
: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.There are a lot of git utilities included.
depot_tools
updates itself automatically when running gclient
tool. To disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0
.
To update package manually, run update_depot_tools.bat
on Windows, or ./update_depot_tools
on Linux or Mac.
On Windows only, running gclient
will install git
and python
.
To contribute change for review:
git new-branch <somename> # Hack git add . git commit -a -m "Fixes goat teleporting" # find reviewers git cl owners git log -- <yourfiles> # Request a review. git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail # Edit change description if needed. git cl desc # If change is approved, flag it to be committed. git cl set-commit # If change needs more work. git rebase-update ... git cl upload -t "Fixes goat teleporter destination to be Australia"
See also open bugs, open reviews, forum or report problems.
Until 2018, our cpplint.py
was a copy of the upstream version at https://github.com/google/styleguide/tree/gh-pages/cpplint. Unfortunately, that repository is not maintained any more. If you want to update cpplint.py
in depot_tools
, just upload a patch to do so. We will figure out a long-term strategy via issue https://crbug.com/916550.
Note that the cpplint.py
here is also used by the Tricium analyzer, so if the cpplint.py here changes, we should also update the copy used there.