commit | 202779b4946ce3ff354fd4a1e9171cf132ca85c0 | [log] [tgz] |
---|---|---|
author | Marc-Antoine Ruel <maruel@google.com> | Fri Feb 07 16:51:00 2020 |
committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Feb 07 16:51:00 2020 |
tree | 194f1944d1d1bb5ca1861e4caa9a8a3861f07de3 | |
parent | 9cc10f207c74c1a1d2b5a34436cb21a5dcc57d92 [diff] |
[swarming] Roll executable, make invocation failure an infra failure This is because the swarming Go client correctly returns non-zero only in the case of an RPC failure, it doesn't return the exit code of the task that results are being collected. This is the right thing, so now all swarming execution shall be considered an infrastructure failure. This was not true with the python client, albeit this recipe module never used the python client, it was just an oversight. Also until the current swarming Go version being rolled in, collect didn't return non-zero on RPC failure. Recipe-Nontrivial-Roll: build Recipe-Nontrivial-Roll: build_limited_scripts_slave Recipe-Nontrivial-Roll: chromiumos Recipe-Nontrivial-Roll: fuchsia Recipe-Nontrivial-Roll: release_scripts Bug: 1049713, 1049756 Change-Id: I30e43bd196092567cd477d325fce8201952698ff Reviewed-on: https://chromium-review.googlesource.com/c/infra/luci/recipes-py/+/2044051 Commit-Queue: Joshua Seaton <joshuaseaton@google.com> Auto-Submit: Marc-Antoine Ruel <maruel@chromium.org> Reviewed-by: Joshua Seaton <joshuaseaton@google.com>
Recipes are a domain-specific language (embedded in python) for specifying sequences of subprocess calls in a cross-platform and testable way.
They allow writing build flows which integrate with the rest of LUCI.
Documentation for the recipe engine (including this file!). Take a look at the user guide for some hints on how to get started. See the implementation details doc for more detailed implementation information about the recipe engine.
user.email
and user.name
are configured in git config
.Run the following to setup the code review tool and create your first review:
# Get `depot_tools` in $PATH if you don't have it git clone https://chromium.googlesource.com/chromium/tools/depot_tools.git $HOME/src/depot_tools export PATH="$PATH:$HOME/src/depot_tools" # Check out the recipe engine repo git clone https://chromium.googlesource.com/infra/luci/recipes-py $HOME/src/recipes-py # make your change cd $HOME/src/recipes-py git new-branch cool_feature # hack hack git commit -a -m "This is awesome" # This will ask for your Google Account credentials. git cl upload -s -r joe@example.com # Wait for approval over email. # Click "Submit to CQ" button or ask reviewer to do it for you. # Wait for the change to be tested and landed automatically.
Use git cl help
and git cl help <cmd>
for more details.