commit | 2033d608299d63987c046f7d048793ee8d50855e | [log] [tgz] |
---|---|---|
author | Devlin Cronin <rdevlin.cronin@chromium.org> | Fri Dec 14 23:54:49 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Fri Dec 14 23:54:49 2018 |
tree | 95a8dd89cc6ddc559a6f70c30c887c4cde4186c7 | |
parent | fb1b995f85d59e04702630d0f17707b4ee56a901 [diff] |
[Extensions] Remove linked_ptr from ManifestHandler[Registry] Remove linked_ptrs from ManifestHandler and ManifestHandlerRegistry, and tweak the ManifestHandlerRegistry interface to be more friendly about passing ownership. - Make ManifestHandlerRegistry::RegisterHandler() public, and explicitly take ownership of the ManifestHandler. - Register ManifestHandlers with ManifestHandlerRegistry::RegisterHandler() directly, rather than going through ManifestHandler::Register(). (The combination of these two changes makes for a less surprising interface, where we do registry->RegisterHandler(make_unique<Handler>()) rather than (new Handler())->Register()) - Store ManifestHandlers in an unsorted vector in ManifestHandlerRegistry, which serves only to maintain ownership. Update the maps to only retain raw pointer references. TBR=halliwell@chromium.org (mechanical change to cast_extensions_api_provider.cc) Bug: 914401 Change-Id: Ib53c44095e8b91ef768422ab9ecd8d71726da4a5 Reviewed-on: https://chromium-review.googlesource.com/c/1374389 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#616880}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .