Google Git
Sign in
chromium / chromium / src / 20575e91a5024839400ccef1377c8ae147fcd96f
commit20575e91a5024839400ccef1377c8ae147fcd96f[log] [tgz]
authordanakj <danakj@chromium.org>Wed Jan 23 16:25:01 2019
committerCommit Bot <commit-bot@chromium.org>Wed Jan 23 16:25:01 2019
tree046423387e6a5256888d0641268760c79df47f38
parent4d4a30d366cf48fd0864c8b6b8c662294f3685c7 [diff]
Remove nullcheck from RenderWidget::SynchronizeVisualProperties

Sync visual properties is only called in response to an IPC. The close
IPC drops the IPC route before removing the WebWidget so IPCs can't
arrive that would SynchronizeVisualProperties() after the WebWidget is
gone.

The one exception is the screen metrics emulator which can call it from
its destructor, but it is also destroyed in CloseWebWidget() before the
WebWidget is destroyed precisely to avoid these sorts of things (with
a TODO about how to make that more clear..).

R=avi@chromium.org

Change-Id: I0621f4e3f4a708dd209b996129b9e17a765d6296
Bug: 912193
Reviewed-on: https://chromium-review.googlesource.com/c/1427881
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625219}
1 file changed
tree: 046423387e6a5256888d0641268760c79df47f38
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. cc/
  8. chrome/
  9. chrome_elf/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .