| commit | 2082afcf3c8afe5002689ff3208d546f5775fb9a | [log] [tgz] |
|---|---|---|
| author | kozyatinskiy <kozyatinskiy@chromium.org> | Fri Oct 14 01:59:36 2016 |
| committer | Commit bot <commit-bot@chromium.org> | Fri Oct 14 02:00:00 2016 |
| tree | 726c350ee4a750f58ed43419a40a02c588c07fda | |
| parent | 6882c91ecd222f3ee2feb42ad73fbc796d5c8172 [diff] |
[inspector] added check that context always survives inspected context Inspected context is created in V8InspectorImpl::contextCreated method and destroyed in V8InspectorImpl::contextDestroyed. Both methods takes valid v8::Local<v8::Context> handle to the same context, it means that context is created before InspectedContext constructor and is always destroyed after InspectedContext destructor therefore context weak callback in inspected context should be never called. It's possible only if inspector client doesn't call contextDestroyed which is considered an error. Therefore CHECK(false) is added into context weak callback to be sure that v8::Context always survives inspected context. BUG=chromium:652548 R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2413583002 Cr-Commit-Position: refs/heads/master@{#40290}
V8 is Google's open source JavaScript engine.
V8 implements ECMAScript as specified in ECMA-262.
V8 is written in C++ and is used in Google Chrome, the open source browser from Google.
V8 can run standalone, or can be embedded into any C++ application.
V8 Project page: https://github.com/v8/v8/wiki
Checkout depot tools, and run
fetch v8
This will checkout V8 into the directory v8 and fetch all of its dependencies. To stay up to date, run
git pull origin
gclient sync
For fetching all branches, add the following into your remote configuration in .git/config:
fetch = +refs/branch-heads/*:refs/remotes/branch-heads/*
fetch = +refs/tags/*:refs/tags/*
Please follow the instructions mentioned on the V8 wiki.