Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2106843005: Use SaveSameObject for Notification.data as well (Closed)

Created:
4 years, 5 months ago by Peter Beverloo
Modified:
4 years, 5 months ago
Reviewers:
haraken, Yuki
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org, Peter Beverloo
Base URL:
https://chromium.googlesource.com/chromium/src.git@n-action-vibrate
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use SaveSameObject for Notification.data as well This allows us to remove our own caching from the Notification class. BUG= Committed: https://crrev.com/519897378576e39311d534f975338fb3eaea0fa5 Cr-Commit-Position: refs/heads/master@{#403456}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -10 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/notifications/Notification.h View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/notifications/Notification.cpp View 1 chunk +3 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/notifications/Notification.idl View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Issue 1974033003 Patch 80001

Messages

Total messages: 14 (5 generated)
Peter Beverloo
+yukishiino PTAL
4 years, 5 months ago (2016-06-29 18:12:12 UTC) #2
haraken
LGTM
4 years, 5 months ago (2016-06-29 23:41:05 UTC) #3
Yuki
LGTM.
4 years, 5 months ago (2016-06-30 03:46:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2106843005/1
4 years, 5 months ago (2016-07-01 12:17:16 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/249137)
4 years, 5 months ago (2016-07-01 13:40:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2106843005/1
4 years, 5 months ago (2016-07-01 13:41:41 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-01 14:55:13 UTC) #11
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-01 14:55:16 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-01 14:56:21 UTC) #14
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/519897378576e39311d534f975338fb3eaea0fa5
Cr-Commit-Position: refs/heads/master@{#403456}

Powered by Google App Engine
This is Rietveld 408576698