Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 2141673002: [DevTools] Always send a copy of worker message through the page. (Closed)

Created:
4 years, 5 months ago by dgozman
Modified:
4 years, 5 months ago
Reviewers:
kozy, pfeldman
CC:
chromium-reviews, kinuko+worker_chromium.org, caseq+blink_chromium.org, lushnikov+blink_chromium.org, falken, pfeldman+blink_chromium.org, haraken, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, horo+watch_chromium.org, sergeyv+blink_chromium.org, kinuko+watch, blink-worker-reviews_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Always send a copy of worker message through the page. This introduces WorkerMessageSource and sends all the worker messages immediately to the page console. Client may filter those out when attached to the worker target. BUG=613882 Committed: https://crrev.com/63fe38c1e6d9eeefd9036f431456c8a359424fa3 Cr-Commit-Position: refs/heads/master@{#404993}

Patch Set 1 #

Patch Set 2 : new approach #

Total comments: 2

Patch Set 3 : addMessageFromWorker #

Total comments: 2

Patch Set 4 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -143 lines) Patch
M third_party/WebKit/LayoutTests/inspector-protocol/resources/worker-console-worker.js View 1 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/worker/worker-console.html View 1 2 3 6 chunks +30 lines, -15 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/worker/worker-console-expected.txt View 1 1 chunk +17 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameConsole.h View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameConsole.cpp View 1 2 2 chunks +4 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/ConsoleMessage.h View 1 3 chunks +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/ConsoleMessage.cpp View 1 3 chunks +14 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorSession.h View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorSession.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/WorkerInspectorController.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/workers/InProcessWorkerObjectProxy.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/InProcessWorkerObjectProxy.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp View 1 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerInspectorProxy.h View 1 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerInspectorProxy.cpp View 1 2 5 chunks +1 line, -24 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerReportingProxy.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerThreadTestHelper.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js View 1 5 chunks +10 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThreadTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8ConsoleAgentImpl.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.h View 1 4 chunks +17 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.cpp View 1 7 chunks +32 lines, -23 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/js_protocol.json View 1 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/public/V8ConsoleTypes.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/public/V8Debugger.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorSessionClient.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebSharedWorkerImpl.h View 1 chunk +0 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 33 (15 generated)
dgozman
Could you please take a look?
4 years, 5 months ago (2016-07-11 18:09:51 UTC) #2
dgozman
Take a look please. New approach.
4 years, 5 months ago (2016-07-11 21:15:29 UTC) #5
pfeldman
lgtm https://codereview.chromium.org/2141673002/diff/20001/third_party/WebKit/Source/core/frame/FrameConsole.h File third_party/WebKit/Source/core/frame/FrameConsole.h (right): https://codereview.chromium.org/2141673002/diff/20001/third_party/WebKit/Source/core/frame/FrameConsole.h#newcode54 third_party/WebKit/Source/core/frame/FrameConsole.h:54: void addWorkerMessage(ConsoleMessage*, const String& workerId); addMessageFromWorker
4 years, 5 months ago (2016-07-11 21:37:28 UTC) #6
kozy
lgtm https://codereview.chromium.org/2141673002/diff/40001/third_party/WebKit/LayoutTests/inspector-protocol/worker/worker-console.html File third_party/WebKit/LayoutTests/inspector-protocol/worker/worker-console.html (right): https://codereview.chromium.org/2141673002/diff/40001/third_party/WebKit/LayoutTests/inspector-protocol/worker/worker-console.html#newcode41 third_party/WebKit/LayoutTests/inspector-protocol/worker/worker-console.html:41: var workerEventHandler = []; It should be an ...
4 years, 5 months ago (2016-07-12 00:45:19 UTC) #7
kozy
lgtm
4 years, 5 months ago (2016-07-12 00:45:20 UTC) #8
dgozman
https://codereview.chromium.org/2141673002/diff/20001/third_party/WebKit/Source/core/frame/FrameConsole.h File third_party/WebKit/Source/core/frame/FrameConsole.h (right): https://codereview.chromium.org/2141673002/diff/20001/third_party/WebKit/Source/core/frame/FrameConsole.h#newcode54 third_party/WebKit/Source/core/frame/FrameConsole.h:54: void addWorkerMessage(ConsoleMessage*, const String& workerId); On 2016/07/11 21:37:27, pfeldman ...
4 years, 5 months ago (2016-07-12 01:16:38 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2141673002/60001
4 years, 5 months ago (2016-07-12 01:19:28 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/199456)
4 years, 5 months ago (2016-07-12 02:49:57 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2141673002/60001
4 years, 5 months ago (2016-07-12 04:50:08 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/190933)
4 years, 5 months ago (2016-07-12 06:18:05 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2141673002/60001
4 years, 5 months ago (2016-07-12 14:19:42 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/261086)
4 years, 5 months ago (2016-07-12 17:24:46 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2141673002/60001
4 years, 5 months ago (2016-07-12 17:33:35 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/191437)
4 years, 5 months ago (2016-07-12 20:58:54 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2141673002/60001
4 years, 5 months ago (2016-07-12 21:40:42 UTC) #28
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 5 months ago (2016-07-13 03:59:33 UTC) #30
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-13 03:59:47 UTC) #31
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 04:01:04 UTC) #33
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/63fe38c1e6d9eeefd9036f431456c8a359424fa3
Cr-Commit-Position: refs/heads/master@{#404993}

Powered by Google App Engine
This is Rietveld 408576698