Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 2159163002: Set Resource Timing transferSize field in Workers (Closed)

Created:
4 years, 5 months ago by Adam Rice
Modified:
4 years, 4 months ago
Reviewers:
Kunihiko Sakamoto, eae
CC:
chromium-reviews, blink-reviews, jshin+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@resource_timing_sizes_render_process
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Set Resource Timing transferSize field in Workers The transferSize field was not correctly set in Worker contexts. Fix it. Also create variants of the PerformanceResourceTiming size field layout tests which use a Worker. The common code between the worker and non-worker tests is factored out into javascript files. BUG=630055 Committed: https://crrev.com/147a3f85d9f0bb1e2a654822a555d470f5fa45d4 Cr-Commit-Position: refs/heads/master@{#408048}

Patch Set 1 #

Patch Set 2 : Remove debug logging #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -362 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/misc/resource-timing-sizes-cache.html View 1 chunk +1 line, -59 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/misc/resource-timing-sizes-cache-worker.html View 1 chunk +2 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/misc/resource-timing-sizes-content-encoding.html View 1 chunk +1 line, -27 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/misc/resource-timing-sizes-content-encoding-worker.html View 1 chunk +2 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/misc/resource-timing-sizes-cors-preflight.html View 1 chunk +1 line, -58 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/misc/resource-timing-sizes-cors-preflight-worker.html View 1 chunk +2 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/misc/resource-timing-sizes-redirect.html View 1 chunk +1 line, -94 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/misc/resource-timing-sizes-redirect-worker.html View 1 chunk +2 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/misc/resource-timing-sizes-xhr-fetch.html View 1 chunk +1 line, -62 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/misc/resource-timing-sizes-xhr-fetch-worker.html View 1 chunk +2 lines, -6 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/misc/resources/resource-timing-sizes-cache.js View 2 chunks +9 lines, -6 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/misc/resources/resource-timing-sizes-content-encoding.js View 2 chunks +10 lines, -6 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/misc/resources/resource-timing-sizes-cors-preflight.js View 2 chunks +11 lines, -7 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/misc/resources/resource-timing-sizes-redirect.js View 1 2 chunks +11 lines, -7 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/misc/resources/resource-timing-sizes-xhr-fetch.js View 2 chunks +10 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/network/ResourceTimingInfo.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 20 (12 generated)
Adam Rice
4 years, 5 months ago (2016-07-21 01:21:58 UTC) #4
Kunihiko Sakamoto
lgtm
4 years, 5 months ago (2016-07-21 02:05:33 UTC) #5
Adam Rice
+eae for Source/platform OWNERS.
4 years, 5 months ago (2016-07-21 02:13:39 UTC) #7
Adam Rice
On 2016/07/21 02:13:39, Adam Rice wrote: > +eae for Source/platform OWNERS. Ping eae. Please reassign ...
4 years, 5 months ago (2016-07-25 02:58:29 UTC) #12
eae
LGTM
4 years, 4 months ago (2016-07-26 17:24:06 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2159163002/40001
4 years, 4 months ago (2016-07-27 03:48:02 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-07-27 05:21:44 UTC) #18
commit-bot: I haz the power
4 years, 4 months ago (2016-07-27 05:23:30 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/147a3f85d9f0bb1e2a654822a555d470f5fa45d4
Cr-Commit-Position: refs/heads/master@{#408048}

Powered by Google App Engine
This is Rietveld 408576698