Google Git
Sign in
chromium / chromium / src / 237be1e74cd01009d94c6fc445e6aae6030269a6
commit237be1e74cd01009d94c6fc445e6aae6030269a6[log] [tgz]
authorTom Anderson <thomasanderson@chromium.org>Fri Nov 03 03:11:21 2017
committerCommit Bot <commit-bot@chromium.org>Fri Nov 03 03:11:21 2017
tree68ebf1875551d23545a6995bd5954f460ec99960
parente801961c799264484584c7bfca14b8d408afc44b [diff]
Gtk: Ensure AvatarButton has pressed state when menu is showing

When using the GTK theme with --enable-native-avatar-button, it's
required that the avatar button have the pressed state when the
profile chooser menu is showing so that it looks pressed.  Previously,
the pressed state was handled by manually setting the ink drop
animation state.  Now, AvatarButton is made a sublcass of MenuButton
and reuses code from there to handle ink drop animation, and ensuring
the state becomes pressed.

Also, this incidentally fixes a bug where the ink drop would get stuck
when right clicking on the avatar button.

BUG=753067
R=msw@chromium.org
CC=sky@chromium.org

Change-Id: I6aafb5499e230859ea1ebe1c5ca6e2375ea63994
Reviewed-on: https://chromium-review.googlesource.com/744967
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513662}
4 files changed
tree: 68ebf1875551d23545a6995bd5954f460ec99960
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. build/
  7. build_overrides/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .