Views: Flip default value of CustomButton::request_focus_on_press_ to false.
CustomButton::request_focus_on_press_ has a default value of true currently.
Since View::RequestFocus uses IsFocusable() when keyboard accessibility is off
(i.e. on Non-Mac platforms), hence only buttons with FocusBehavior::ALWAYS can
actually gain focus if they have request_focus_on_press_ set to true. Most
CustomButton subclasses like say ToolbarButton or TabCloseButton, which have
FocusBehavior::ACCESSIBLE_ONLY, rely on this behavior and do not explicitly
override request_focus_on_press_ to false.
This CL corrects the request_focus_on_press_ value on the CustomButton
subclasses by flipping the default value to false. Since only buttons with
request_focus_on_press_ set to true and having FocusBehavior::ALWAYS are
intended to gain focus on a mouse press, all ConfigureDefaultFocus call sites
are examined and set_request_focus_on_press is set to the appropriate value.
BUG=NONE
Review-Url: https://codereview.chromium.org/1963563002
Cr-Commit-Position: refs/heads/master@{#394020}
30 files changed
