[HttpCache] LOAD_ONLY_FROM_CACHE should not imply LOAD_PREFERRING_CACHE

[HttpCache] LOAD_ONLY_FROM_CACHE should not imply LOAD_PREFERRING_CACHE

LOAD_ONLY_FROM_CACHE won't go to the network, but it also skips the check to
see if the cache entry is valid. Some clients need to load only from cache,
but also ensure that the returned entry is valid. To accomplish this, this CL:

1) Renames LOAD_PREFERRING_CACHE -> LOAD_SKIP_CACHE_VALIDATION
2) Changes LOAD_ONLY_FROM_CACHE to check entry validity by default
3) Changes all existing uses of LOAD_ONLY_FROM_CACHE to also add
   LOAD_SKIP_CACHE_VALIDATION, keeping the old behavior

BUG=652649
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/a067deede18317270cd2f118615650a2a755de8e
Cr-Commit-Position: refs/heads/master@{#428026}

[jkarlin, 2016-10-05 12:37:58]

Description was changed from

==========
[HttpCache] LOAD_ONLY_FROM_CACHE should not imply LOAD_PREFERRING_CACHE

LOAD_ONLY_FROM_CACHE skips validation, similar to LOAD_PREFERRING_CACHE. This
CL changes LOAD_ONLY_FROM_CACHE to not skip validation unless
LOAD_PREFERRING_CACHE is also present. This makes it possible to check the
cache for valid entries.

BUG=652649
==========

to

==========
[HttpCache] LOAD_ONLY_FROM_CACHE should not imply LOAD_PREFERRING_CACHE

LOAD_ONLY_FROM_CACHE skips validation, similar to LOAD_PREFERRING_CACHE. This
CL changes LOAD_ONLY_FROM_CACHE to not skip validation unless
LOAD_PREFERRING_CACHE is also present. This makes it possible to check the
cache for valid entries.

BUG=652649
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[jkarlin, 2016-10-05 12:38:04]

The CQ bit was checked by jkarlin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-05 12:38:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 12:49:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-05 12:49:48]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[jkarlin, 2016-10-05 13:31:31]

The CQ bit was checked by jkarlin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-05 13:31:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jkarlin, 2016-10-05 13:44:10]

Description was changed from

==========
[HttpCache] LOAD_ONLY_FROM_CACHE should not imply LOAD_PREFERRING_CACHE

LOAD_ONLY_FROM_CACHE skips validation, similar to LOAD_PREFERRING_CACHE. This
CL changes LOAD_ONLY_FROM_CACHE to not skip validation unless
LOAD_PREFERRING_CACHE is also present. This makes it possible to check the
cache for valid entries.

BUG=652649
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
[HttpCache] LOAD_ONLY_FROM_CACHE should not imply LOAD_PREFERRING_CACHE

LOAD_ONLY_FROM_CACHE won't go to the network, but it also skips the check to see
if the cache entry is valid. Some clients need to load only from cache, but also
ensure that the returned entry is valid. To accomplish this, this CL:

1) Renames LOAD_PREFERRING_CACHE -> LOAD_SKIP_CACHE_VALIDATION
2) Changes LOAD_ONLY_FROM_CACHE to check cache validity by default
3) Changes all existing uses of LOAD_ONLY_FROM_CACHE to also add
   LOAD_SKIP_CACHE_VALIDATION, keeping the old behavior

BUG=652649
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[jkarlin, 2016-10-05 13:44:59]

Description was changed from

==========
[HttpCache] LOAD_ONLY_FROM_CACHE should not imply LOAD_PREFERRING_CACHE

LOAD_ONLY_FROM_CACHE won't go to the network, but it also skips the check to see
if the cache entry is valid. Some clients need to load only from cache, but also
ensure that the returned entry is valid. To accomplish this, this CL:

1) Renames LOAD_PREFERRING_CACHE -> LOAD_SKIP_CACHE_VALIDATION
2) Changes LOAD_ONLY_FROM_CACHE to check cache validity by default
3) Changes all existing uses of LOAD_ONLY_FROM_CACHE to also add
   LOAD_SKIP_CACHE_VALIDATION, keeping the old behavior

BUG=652649
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
[HttpCache] LOAD_ONLY_FROM_CACHE should not imply LOAD_PREFERRING_CACHE

LOAD_ONLY_FROM_CACHE won't go to the network, but it also skips the check to
see if the cache entry is valid. Some clients need to load only from cache,
but also ensure that the returned entry is valid. To accomplish this, this CL:

1) Renames LOAD_PREFERRING_CACHE -> LOAD_SKIP_CACHE_VALIDATION
2) Changes LOAD_ONLY_FROM_CACHE to check cache validity by default
3) Changes all existing uses of LOAD_ONLY_FROM_CACHE to also add
   LOAD_SKIP_CACHE_VALIDATION, keeping the old behavior

BUG=652649
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[commit-bot: I haz the power, 2016-10-05 14:24:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-05 14:24:43]

Dry run: This issue passed the CQ dry run.

[jkarlin, 2016-10-07 15:04:04]

The CQ bit was checked by jkarlin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-07 15:04:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jkarlin, 2016-10-07 15:05:13]

Description was changed from

==========
[HttpCache] LOAD_ONLY_FROM_CACHE should not imply LOAD_PREFERRING_CACHE

LOAD_ONLY_FROM_CACHE won't go to the network, but it also skips the check to
see if the cache entry is valid. Some clients need to load only from cache,
but also ensure that the returned entry is valid. To accomplish this, this CL:

1) Renames LOAD_PREFERRING_CACHE -> LOAD_SKIP_CACHE_VALIDATION
2) Changes LOAD_ONLY_FROM_CACHE to check cache validity by default
3) Changes all existing uses of LOAD_ONLY_FROM_CACHE to also add
   LOAD_SKIP_CACHE_VALIDATION, keeping the old behavior

BUG=652649
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
[HttpCache] LOAD_ONLY_FROM_CACHE should not imply LOAD_PREFERRING_CACHE

LOAD_ONLY_FROM_CACHE won't go to the network, but it also skips the check to
see if the cache entry is valid. Some clients need to load only from cache,
but also ensure that the returned entry is valid. To accomplish this, this CL:

1) Renames LOAD_PREFERRING_CACHE -> LOAD_SKIP_CACHE_VALIDATION
2) Changes LOAD_ONLY_FROM_CACHE to check entry validity by default
3) Changes all existing uses of LOAD_ONLY_FROM_CACHE to also add
   LOAD_SKIP_CACHE_VALIDATION, keeping the old behavior

BUG=652649
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[jkarlin, 2016-10-07 15:05:36]

jkarlin@chromium.org changed reviewers:
+ gavinp@chromium.org

[jkarlin, 2016-10-07 15:05:37]

gavinp@ PTAL at everything, thank you!

[commit-bot: I haz the power, 2016-10-07 15:25:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-07 15:25:10]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[jkarlin, 2016-10-07 16:22:20]

The CQ bit was checked by jkarlin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-07 16:22:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-07 16:41:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-07 16:41:32]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[gavinp, 2016-10-07 16:45:09]

It's somewhat tricky that LOAD_SKIP_CACHE_VALIDATION has two meanings: one where
it respects Vary, and one where it overrides Vary, depending on
LOAD_ONLY_FROM_CACHE.

Is there a way away from that?

https://codereview.chromium.org/2398613002/diff/60001/net/http/http_cache_tra...
File net/http/http_cache_transaction.cc (right):

https://codereview.chromium.org/2398613002/diff/60001/net/http/http_cache_tra...
net/http/http_cache_transaction.cc:1994: RequiresValidation() !=
VALIDATION_NONE)
Nit: Doesn't this need a { per our style guide?

[jkarlin, 2016-10-07 16:49:29]

The CQ bit was checked by jkarlin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-07 16:49:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jkarlin, 2016-10-11 15:23:34]

The CQ bit was checked by jkarlin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-11 15:23:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-11 15:36:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-11 15:36:29]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[jkarlin, 2016-10-12 18:39:40]

Patchset #5 (id:80001) has been deleted

[jkarlin, 2016-10-12 18:39:49]

Patchset #5 (id:100001) has been deleted

[jkarlin, 2016-10-12 18:42:26]

The CQ bit was checked by jkarlin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-12 18:43:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-12 20:30:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-12 20:30:59]

Dry run: This issue passed the CQ dry run.

[jkarlin, 2016-10-13 15:33:58]

https://codereview.chromium.org/2398613002/diff/60001/net/http/http_cache_tra...
File net/http/http_cache_transaction.cc (right):

https://codereview.chromium.org/2398613002/diff/60001/net/http/http_cache_tra...
net/http/http_cache_transaction.cc:1994: RequiresValidation() !=
VALIDATION_NONE)
On 2016/10/07 16:45:09, gavinp wrote:
> Nit: Doesn't this need a { per our style guide?

Done.

[jkarlin, 2016-10-13 15:36:31]

On 2016/10/07 16:45:09, gavinp wrote:
> It's somewhat tricky that LOAD_SKIP_CACHE_VALIDATION has two meanings: one
where
> it respects Vary, and one where it overrides Vary, depending on
> LOAD_ONLY_FROM_CACHE.
> 
> Is there a way away from that?

One option is to respect vary for all requests. WDYT?

[jkarlin, 2016-10-13 16:37:15]

The CQ bit was checked by jkarlin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-13 16:37:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-13 17:47:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-13 17:47:15]

Dry run: This issue passed the CQ dry run.

[jkarlin, 2016-10-13 17:51:23]

On 2016/10/13 15:36:31, jkarlin wrote:
> On 2016/10/07 16:45:09, gavinp wrote:
> > It's somewhat tricky that LOAD_SKIP_CACHE_VALIDATION has two meanings: one
> where
> > it respects Vary, and one where it overrides Vary, depending on
> > LOAD_ONLY_FROM_CACHE.
> > 
> > Is there a way away from that?
> 
> One option is to respect vary for all requests. WDYT?

Seems to pass the try bots okay.

[jkarlin, 2016-10-18 11:59:23]

Ping gavinp@, WDYT?

[jkarlin, 2016-10-20 15:40:12]

gavinp@ PTAL. I think we should always respect vary.

[gavinp, 2016-10-20 16:26:53]

On 2016/10/20 15:40:12, jkarlin wrote:
> gavinp@ PTAL. I think we should always respect vary.

Sorry, been sick. Now back in the office, looking this over and thinking about
it. Should respond later today.

[gavinp, 2016-10-20 16:26:53]

On 2016/10/20 15:40:12, jkarlin wrote:
> gavinp@ PTAL. I think we should always respect vary.

Sorry, been sick. Now back in the office, looking this over and thinking about
it. Should respond later today.

[gavinp, 2016-10-21 14:27:48]

lgtm, thanks!

[jkarlin, 2016-10-21 14:28:58]

Thanks!

[jkarlin, 2016-10-21 14:29:05]

The CQ bit was checked by jkarlin@chromium.org

[jkarlin, 2016-10-21 14:29:25]

The CQ bit was unchecked by jkarlin@chromium.org

[commit-bot: I haz the power, 2016-10-21 14:29:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jkarlin, 2016-10-21 14:29:52]

On 2016/10/21 14:29:28, commit-bot: I haz the power wrote:
> CQ is trying da patch. Follow status at
>  
>
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

Whoops, forgot that the rest of the CL needs a review :)

[jkarlin, 2016-10-21 14:33:52]

jkarlin@chromium.org changed reviewers:
+ ellyjones@chromium.org, jochen@chromium.org, torne@chromium.org

[jkarlin, 2016-10-21 14:33:53]

ellyjones@chromium.org: Please review changes in ios/

torne@chromium.org: Please review changes in android_webview/

jochen@chromium.org: Please review changes in content, chrome, and components 

Thanks!

[jochen (gone - plz use gerrit), 2016-10-24 07:22:42]

lgtm

[Torne, 2016-10-24 11:59:49]

android_webview LGTM

[jkarlin, 2016-10-27 12:08:52]

jkarlin@chromium.org changed reviewers:
- ellyjones@chromium.org

[jkarlin, 2016-10-27 12:10:04]

jkarlin@chromium.org changed reviewers:
+ droger@chromium.org

[jkarlin, 2016-10-27 12:10:05]

droger@chromium.org: Please review changes in ios/ Thanks!

[jkarlin, 2016-10-27 12:10:53]

The CQ bit was checked by jkarlin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 12:11:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 13:23:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 13:23:38]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[droger, 2016-10-27 13:44:55]

lgtm

[jkarlin, 2016-10-27 13:46:56]

The CQ bit was checked by jkarlin@chromium.org

[commit-bot: I haz the power, 2016-10-27 13:47:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jkarlin, 2016-10-27 13:48:13]

Thanks all!

[commit-bot: I haz the power, 2016-10-27 14:48:57]

Description was changed from

==========
[HttpCache] LOAD_ONLY_FROM_CACHE should not imply LOAD_PREFERRING_CACHE

LOAD_ONLY_FROM_CACHE won't go to the network, but it also skips the check to
see if the cache entry is valid. Some clients need to load only from cache,
but also ensure that the returned entry is valid. To accomplish this, this CL:

1) Renames LOAD_PREFERRING_CACHE -> LOAD_SKIP_CACHE_VALIDATION
2) Changes LOAD_ONLY_FROM_CACHE to check entry validity by default
3) Changes all existing uses of LOAD_ONLY_FROM_CACHE to also add
   LOAD_SKIP_CACHE_VALIDATION, keeping the old behavior

BUG=652649
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
[HttpCache] LOAD_ONLY_FROM_CACHE should not imply LOAD_PREFERRING_CACHE

LOAD_ONLY_FROM_CACHE won't go to the network, but it also skips the check to
see if the cache entry is valid. Some clients need to load only from cache,
but also ensure that the returned entry is valid. To accomplish this, this CL:

1) Renames LOAD_PREFERRING_CACHE -> LOAD_SKIP_CACHE_VALIDATION
2) Changes LOAD_ONLY_FROM_CACHE to check entry validity by default
3) Changes all existing uses of LOAD_ONLY_FROM_CACHE to also add
   LOAD_SKIP_CACHE_VALIDATION, keeping the old behavior

BUG=652649
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[commit-bot: I haz the power, 2016-10-27 14:48:59]

Committed patchset #7 (id:160001)

[commit-bot: I haz the power, 2016-10-27 14:51:15]

Description was changed from

==========
[HttpCache] LOAD_ONLY_FROM_CACHE should not imply LOAD_PREFERRING_CACHE

LOAD_ONLY_FROM_CACHE won't go to the network, but it also skips the check to
see if the cache entry is valid. Some clients need to load only from cache,
but also ensure that the returned entry is valid. To accomplish this, this CL:

1) Renames LOAD_PREFERRING_CACHE -> LOAD_SKIP_CACHE_VALIDATION
2) Changes LOAD_ONLY_FROM_CACHE to check entry validity by default
3) Changes all existing uses of LOAD_ONLY_FROM_CACHE to also add
   LOAD_SKIP_CACHE_VALIDATION, keeping the old behavior

BUG=652649
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
[HttpCache] LOAD_ONLY_FROM_CACHE should not imply LOAD_PREFERRING_CACHE

LOAD_ONLY_FROM_CACHE won't go to the network, but it also skips the check to
see if the cache entry is valid. Some clients need to load only from cache,
but also ensure that the returned entry is valid. To accomplish this, this CL:

1) Renames LOAD_PREFERRING_CACHE -> LOAD_SKIP_CACHE_VALIDATION
2) Changes LOAD_ONLY_FROM_CACHE to check entry validity by default
3) Changes all existing uses of LOAD_ONLY_FROM_CACHE to also add
   LOAD_SKIP_CACHE_VALIDATION, keeping the old behavior

BUG=652649
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/a067deede18317270cd2f118615650a2a755de8e
Cr-Commit-Position: refs/heads/master@{#428026}
==========

[commit-bot: I haz the power, 2016-10-27 14:51:17]

Patchset 7 (id:??) landed as
https://crrev.com/a067deede18317270cd2f118615650a2a755de8e
Cr-Commit-Position: refs/heads/master@{#428026}