commit | 2401ba3b8dfcfc2d940b0f84b97f625e377470a7 | [log] [tgz] |
---|---|---|
author | David Bokan <bokan@chromium.org> | Fri Dec 14 18:12:10 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Fri Dec 14 18:12:10 2018 |
tree | a63f3c3ee8fa379be22e1c81a8a4f6c9bc58c644 | |
parent | bae0b5e9ba8af723aaffb213a3157ed3e160f77e [diff] |
[BlinkGenPropertyTrees] Fix SitePerProcessHitTestBrowserTest This CL fixes the test: SitePerProcessHitTestBrowserTest.RootConsumesScrollDuringOverscrollGesture Turning on BlinkGenPropertyTrees changes how OOPIFs are clipped in non trivial clipping scenarios, such as border-radius. In this test, the OOPIF has a border-radius. Prior to BGPT, the OOPIF would not be masked correctly. The fix here is to simply remove the failing ASSERT. It's simply checking that events sent to the given point get routed to the iframe's RenderWidgetHostView. With BGPT, we correctly perform masking so the hit test realizes the result will be ambiguous and requires a hit test in the renderer. Additional details are in the bug. The ASSERT is unneeded as the InputEventAckWaiter will wait on the ACK in the child RWHV so if it gets mis-routed the waiter will never awaken. Bug: 912334 Change-Id: Iaf76181ed7e89971e445076905057ebde30abffb Reviewed-on: https://chromium-review.googlesource.com/c/1374467 Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by: Nasko Oskov <nasko@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#616744}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .