Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(746)

Issue 2428633003: Mark layout test NeedsRebaseline (Closed)

Created:
4 years, 2 months ago by Clemens Hammacher
Modified:
4 years, 2 months ago
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mark layout test NeedsRebaseline V8 change has landed, regenerate expected output now. V8 CL: https://codereview.chromium.org/2415073003. Set NeedsManualRebaseline in https://codereview.chromium.org/2423113002. BUG=656622 R=jochen@chromium.org, kozyatinskiy@chromium.org Committed: https://crrev.com/880f4966dd58919a2b32c6a8d4f11579bb1aa004 Cr-Commit-Position: refs/heads/master@{#426193}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (2 generated)
kozy
lgtm
4 years, 2 months ago (2016-10-18 14:42:21 UTC) #1
Clemens Hammacher
4 years, 2 months ago (2016-10-19 13:30:21 UTC) #2
jochen (gone - plz use gerrit)
lgtm
4 years, 2 months ago (2016-10-19 14:05:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2428633003/1
4 years, 2 months ago (2016-10-19 14:09:14 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-19 15:11:35 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:08:28 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/880f4966dd58919a2b32c6a8d4f11579bb1aa004
Cr-Commit-Position: refs/heads/master@{#426193}

Powered by Google App Engine
This is Rietveld 408576698