Chromium Code Reviews

Issue 2431003003: Introduce ServiceWorkerNavigationPreload feature name (Closed)

Created:
4 years, 2 months ago by horo
Modified:
4 years, 2 months ago
Reviewers:
falken, tkent, ncarter (slow)
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, shimazu+serviceworker_chromium.org, serviceworker-reviews, jam, kinuko+serviceworker, nhiroki, blink-reviews-api_chromium.org, dglazkov+blink, darin-cc_chromium.org, blink-reviews, horo+watch_chromium.org, falken+watch_chromium.org, tzik, kinuko+watch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Introduce ServiceWorkerNavigationPreload feature name https://crrev.com/2389693002 added NavigationPreload runtime flag as experimental status. This feature is enabled when "--enable-experimental-web-platform-features" flag is set. But according to the comment https://crrev.com/2410333006/#msg42 we should introduce a new flag instead. So this CL introduces ServiceWorkerNavigationPreload feature which is enabled when "--enable-features=ServiceWorkerNavigationPreload" flag is set. BUG=649558 Committed: https://crrev.com/752388328b9fa105ce1eb822e0a58e33f1a892ef Cr-Commit-Position: refs/heads/master@{#426395}

Patch Set 1 #

Total comments: 1

Patch Set 2 : alphabetical order #

Unified diffs Side-by-side diffs Stats (+24 lines, -31 lines)
M content/child/runtime_features.cc View 1 chunk +3 lines, -0 lines 0 comments
M content/public/common/content_features.h View 1 chunk +1 line, -0 lines 0 comments
M content/public/common/content_features.cc View 1 chunk +6 lines, -0 lines 0 comments
M third_party/WebKit/LayoutTests/FlagExpectations/enable-browser-side-navigation View 1 chunk +1 line, -0 lines 0 comments
M third_party/WebKit/LayoutTests/LeakExpectations View 1 chunk +2 lines, -0 lines 0 comments
M third_party/WebKit/LayoutTests/VirtualTestSuites View 1 chunk +5 lines, -0 lines 0 comments
M third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 2 chunks +0 lines, -7 lines 0 comments
A third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload/http/tests/serviceworker/README.txt View 1 chunk +1 line, -0 lines 0 comments
A + third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt View 2 chunks +0 lines, -8 lines 0 comments
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 2 chunks +0 lines, -8 lines 0 comments
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt View 2 chunks +0 lines, -8 lines 0 comments
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 1 chunk +1 line, -1 line 0 comments
M third_party/WebKit/Source/web/WebRuntimeFeatures.cpp View 1 chunk +4 lines, -0 lines 0 comments
M third_party/WebKit/public/web/WebRuntimeFeatures.h View 1 chunk +1 line, -0 lines 0 comments

Messages

Total messages: 21 (12 generated)
horo
falken@ Could you please review this?
4 years, 2 months ago (2016-10-19 04:13:58 UTC) #3
falken
lgtm https://codereview.chromium.org/2431003003/diff/1/content/public/common/content_features.h File content/public/common/content_features.h (right): https://codereview.chromium.org/2431003003/diff/1/content/public/common/content_features.h#newcode48 content/public/common/content_features.h:48: CONTENT_EXPORT extern const base::Feature kServiceWorkerNavigationPreload; nit: alphabetical order
4 years, 2 months ago (2016-10-19 04:43:09 UTC) #4
horo
tkent@ Please review RuntimeEnabledFeatures.in, WebRuntimeFeatures.cpp and WebRuntimeFeatures.h.
4 years, 2 months ago (2016-10-19 04:55:48 UTC) #6
horo
nick@ Could you please review runtime_features.*?
4 years, 2 months ago (2016-10-19 04:57:35 UTC) #9
tkent
On 2016/10/19 at 04:55:48, horo wrote: > tkent@ > Please review RuntimeEnabledFeatures.in, WebRuntimeFeatures.cpp and WebRuntimeFeatures.h. ...
4 years, 2 months ago (2016-10-19 05:29:27 UTC) #11
ncarter (slow)
content lgtm
4 years, 2 months ago (2016-10-19 17:37:19 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2431003003/20001
4 years, 2 months ago (2016-10-20 00:17:42 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-20 03:56:52 UTC) #19
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:15:16 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/752388328b9fa105ce1eb822e0a58e33f1a892ef
Cr-Commit-Position: refs/heads/master@{#426395}

Powered by Google App Engine