Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issue 2432083003: Add a nbsp at the the end of the text when the next text has a leading space. (Closed)

Created:
4 years, 2 months ago by joone
Modified:
4 years, 2 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a nbsp at the the end of the text when the next text has a leading space. This is a regression caused by https://codereview.chromium.org/2175163004. The above CL adds a plain space between text nodes, but a nbsp should be added if the next text node has a leading plain space. If not, two spaces are collapsed into one plain space. BUG=657631 TEST=editing/inserting/insert-space.html Committed: https://crrev.com/952d55918cdb455223cabf647cef859486a37b0f Cr-Commit-Position: refs/heads/master@{#426420}

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix indentation in test case #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/editing/inserting/insert-space.html View 1 2 chunks +14 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
joone
Hi yosin@ please review this CL. Thanks!
4 years, 2 months ago (2016-10-20 00:25:55 UTC) #4
yosin_UTC9
lgtm w/ small nit https://codereview.chromium.org/2432083003/diff/1/third_party/WebKit/LayoutTests/editing/inserting/insert-space.html File third_party/WebKit/LayoutTests/editing/inserting/insert-space.html (right): https://codereview.chromium.org/2432083003/diff/1/third_party/WebKit/LayoutTests/editing/inserting/insert-space.html#newcode41 third_party/WebKit/LayoutTests/editing/inserting/insert-space.html:41: var para = selection.document.getElementById('para'); nit: ...
4 years, 2 months ago (2016-10-20 01:29:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2432083003/20001
4 years, 2 months ago (2016-10-20 04:50:04 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-20 06:13:04 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:16:16 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/952d55918cdb455223cabf647cef859486a37b0f
Cr-Commit-Position: refs/heads/master@{#426420}

Powered by Google App Engine
This is Rietveld 408576698