Google Git
Sign in
chromium / infra / luci / recipes-py / 2438e081638a16b8de53752c5a78c807195ed186
commit2438e081638a16b8de53752c5a78c807195ed186[log] [tgz]
authorGarrett Beaty <gbeaty@chromium.org>Wed Jan 08 21:44:50 2020
committerLUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Jan 08 21:44:50 2020
treed1e9bcd4a85858e64071dc4a5ba52ec3ea430501
parenta100ae5fb1cd5a66508d69f9bee7fb69b70b0135 [diff]
Return a disabled ModuleTestData from DisabledTestData.

Currently, the hooks provided by module test data require verbose code
because DisabledTestData.get_module_test_data returns itself, which
doesn't have the dict interface that ModuleTestData does. This requires
modules to check if the test data is enabled before attempting to
extract values from it. Returning a disabled ModuleTestData allows for
that paradigm to continue working while enabling a simpler flow if the
default case for testing is the same as the production case: simply call
test_data.get('key', default_value).

Change-Id: I49a5b8f71966fdfab7eee4b7832b1a3bebb90ea5
Reviewed-on: https://chromium-review.googlesource.com/c/infra/luci/recipes-py/+/1991829
Auto-Submit: Garrett Beaty <gbeaty@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
1 file changed
tree: d1e9bcd4a85858e64071dc4a5ba52ec3ea430501
  1. doc/
  2. infra/
  3. misc/
  4. recipe_engine/
  5. recipe_modules/
  6. recipe_proto/
  7. recipes/
  8. unittests/
  9. .gitattributes
  10. .gitignore
  11. .style.yapf
  12. .vpython
  13. AUTHORS
  14. codereview.settings
  15. CONTRIBUTORS
  16. LICENSE
  17. OWNERS
  18. PRESUBMIT.py
  19. README.md
  20. README.recipes.md
  21. recipes.py
README.md

Recipes

Recipes are a domain-specific language (embedded in python) for specifying sequences of subprocess calls in a cross-platform and testable way.

They allow writing build flows which integrate with the rest of LUCI.

Documentation for the recipe engine (including this file!). Take a look at the user guide for some hints on how to get started. See the implementation details doc for more detailed implementation information about the recipe engine.

Contributing

  • Sign the Google CLA.
  • Make sure your user.email and user.name are configured in git config.

Run the following to setup the code review tool and create your first review:

# Get `depot_tools` in $PATH if you don't have it
git clone https://chromium.googlesource.com/chromium/tools/depot_tools.git $HOME/src/depot_tools
export PATH="$PATH:$HOME/src/depot_tools"

# Check out the recipe engine repo
git clone https://chromium.googlesource.com/infra/luci/recipes-py $HOME/src/recipes-py

# make your change
cd $HOME/src/recipes-py
git new-branch cool_feature
# hack hack
git commit -a -m "This is awesome"

# This will ask for your Google Account credentials.
git cl upload -s -r joe@example.com
# Wait for approval over email.
# Click "Submit to CQ" button or ask reviewer to do it for you.
# Wait for the change to be tested and landed automatically.

Use git cl help and git cl help <cmd> for more details.