Add HTTP/2 error code NO_ERROR.

Add HTTP/2 error code NO_ERROR.

Add HTTP/2 error code NO_ERROR defined by RFC7540 Section 7.

This CL lands server change 137070429 by bnc.

BUG=606990, 488484
Committed: https://crrev.com/c22b581e818b5371b217aa0b8a6758560138bede
Cr-Commit-Position: refs/heads/master@{#427942}

[Bence, 2016-10-24 20:55:04]

The CQ bit was checked by bnc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-24 20:56:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-24 21:20:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-24 21:20:14]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Bence, 2016-10-25 00:16:27]

bnc@chromium.org changed reviewers:
+ xunjieli@chromium.org

[Bence, 2016-10-25 00:16:27]

Helen: PTAL.  Thank you.

[xunjieli, 2016-10-25 17:12:50]

It will be nice if we can get rid of RST_STREAM_INVALID and have
RST_STREAM_NO_ERROR as 0. That way translating between status NO_ERROR and
RST_STREAM_NO_ERROR will require less mental effort. I guess we can't get rid of
RST_STREAM_INVALID, so this lgtm.

https://codereview.chromium.org/2445113002/diff/1/net/spdy/spdy_session.cc
File net/spdy/spdy_session.cc (right):

https://codereview.chromium.org/2445113002/diff/1/net/spdy/spdy_session.cc#ne...
net/spdy/spdy_session.cc:2332: if (status == RST_STREAM_NO_ERROR) {
The new code got rid of handling of status == 0 (RST_STREAM_INVALID), should we
make sure that the case will never happen by adding a
DCHECK_NE(RST_STREAM_INVALID, status) before this line?

[mmenke, 2016-10-25 17:15:30]

mmenke@chromium.org changed reviewers:
+ mmenke@chromium.org

[mmenke, 2016-10-25 17:15:31]

https://codereview.chromium.org/2445113002/diff/1/net/base/net_error_list.h
File net/base/net_error_list.h (right):

https://codereview.chromium.org/2445113002/diff/1/net/base/net_error_list.h#n...
net/base/net_error_list.h:682: // Received HTTP/2 RST_STREAM frame with NO_ERROR
error code.
Driveby nit:  Worth mentioning it's only used internally by HTTP/2 code, and
should not make it above the SpdyStream layer?

[Bence, 2016-10-25 18:18:56]

The CQ bit was checked by bnc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-25 18:19:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 18:22:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-25 18:22:02]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Bence, 2016-10-25 19:47:23]

The CQ bit was checked by bnc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-25 19:48:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 21:02:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-25 21:02:59]

Dry run: This issue passed the CQ dry run.

[Bence, 2016-10-25 22:11:24]

PTAL.  Thank you.

https://codereview.chromium.org/2445113002/diff/1/net/base/net_error_list.h
File net/base/net_error_list.h (right):

https://codereview.chromium.org/2445113002/diff/1/net/base/net_error_list.h#n...
net/base/net_error_list.h:682: // Received HTTP/2 RST_STREAM frame with NO_ERROR
error code.
On 2016/10/25 17:15:30, mmenke wrote:
> Driveby nit:  Worth mentioning it's only used internally by HTTP/2 code, and
> should not make it above the SpdyStream layer?

Done.

https://codereview.chromium.org/2445113002/diff/1/net/spdy/spdy_session.cc
File net/spdy/spdy_session.cc (right):

https://codereview.chromium.org/2445113002/diff/1/net/spdy/spdy_session.cc#ne...
net/spdy/spdy_session.cc:2332: if (status == RST_STREAM_NO_ERROR) {
On 2016/10/25 17:12:49, xunjieli wrote:
> The new code got rid of handling of status == 0 (RST_STREAM_INVALID), should
we
> make sure that the case will never happen by adding a
> DCHECK_NE(RST_STREAM_INVALID, status) before this line?

I changed the value of RST_STREAM_NO_ERROR to 0, so this is not necessary any
more.

[xunjieli, 2016-10-26 17:54:19]

lgtm!

[Bence, 2016-10-26 18:15:05]

The CQ bit was checked by bnc@chromium.org

[Bence, 2016-10-26 18:15:25]

The CQ bit was unchecked by bnc@chromium.org

[Bence, 2016-10-26 18:18:10]

bnc@chromium.org changed reviewers:
+ holte@chromium.org

[Bence, 2016-10-26 18:18:11]

Steven: PTAL at tools/metrics/histograms/.  Thank you.

[Steven Holte, 2016-10-26 22:20:32]

lgtm

[Bence, 2016-10-27 01:57:58]

The CQ bit was checked by bnc@chromium.org

[Bence, 2016-10-27 01:57:59]

The CQ bit was unchecked by bnc@chromium.org

[Bence, 2016-10-27 01:58:01]

The CQ bit was checked by bnc@chromium.org

[commit-bot: I haz the power, 2016-10-27 01:58:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 04:46:09]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-27 04:49:00]

Description was changed from

==========
Add HTTP/2 error code NO_ERROR.

Add HTTP/2 error code NO_ERROR defined by RFC7540 Section 7.

This CL lands server change 137070429 by bnc.

BUG=606990, 488484
==========

to

==========
Add HTTP/2 error code NO_ERROR.

Add HTTP/2 error code NO_ERROR defined by RFC7540 Section 7.

This CL lands server change 137070429 by bnc.

BUG=606990, 488484

Committed: https://crrev.com/c22b581e818b5371b217aa0b8a6758560138bede
Cr-Commit-Position: refs/heads/master@{#427942}
==========

[commit-bot: I haz the power, 2016-10-27 04:49:01]

Patchset 3 (id:??) landed as
https://crrev.com/c22b581e818b5371b217aa0b8a6758560138bede
Cr-Commit-Position: refs/heads/master@{#427942}

[Bence, 2016-11-11 15:08:44]

This CL is actually for https://crbug.com/603182 instead of
https://crbug.com/606990 as stated in the description.  Sorry about the mistake.