Google Git
Sign in
chromium / chromium / src / 250cef84d714b3386a3910845842ea12c3a7abed
commit250cef84d714b3386a3910845842ea12c3a7abed[log] [tgz]
authorArthur Sonzogni <arthursonzogni@chromium.org>Wed Jun 13 11:37:25 2018
committerCommit Bot <commit-bot@chromium.org>Wed Jun 13 11:37:25 2018
tree843dd71382ed27573a51129da5f8b13c33ddf237
parent6c0dc5d1c0746b48cd7f8057bf3379d1f21bb308 [diff]
Fix test: drag-files-to-editable-element.html

The tested feature regressed, but no one realized it, because the test continued
to pass.

Instead of displaying the filenames in the <div>, a new navigation to the file
happened. Starting the navigation causes the current Document to stop and the
test to finish early. The tests finished before it has executed any assertions.

This CL fixes the test, but not the regression.

Bug: 821455, 831155
Change-Id: I61b9cca80677ca2caed72b0e9cf6074f73c2ad6a
Reviewed-on: https://chromium-review.googlesource.com/1094879
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566800}
3 files changed
tree: 843dd71382ed27573a51129da5f8b13c33ddf237
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. build/
  7. build_overrides/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. webrunner/
  53. .clang-format
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. AUTHORS
  61. BUILD.gn
  62. CODE_OF_CONDUCT.md
  63. codereview.settings
  64. DEPS
  65. ENG_REVIEW_OWNERS
  66. LICENSE
  67. LICENSE.chromium_os
  68. OWNERS
  69. PRESUBMIT.py
  70. PRESUBMIT_test.py
  71. PRESUBMIT_test_mocks.py
  72. README.md
  73. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .