Google Git
Sign in
chromium / chromium / src / 253ee7c5b71828f5a0c3856ba30aa0a5679a5c7a
commit253ee7c5b71828f5a0c3856ba30aa0a5679a5c7a[log] [tgz]
authorErik Jensen <rkjnsn@chromium.org>Sat Jan 26 01:18:40 2019
committerCommit Bot <commit-bot@chromium.org>Sat Jan 26 01:18:40 2019
tree3dfc8cb8ac4cab4733de5a9c0320b8ed4940cf44
parent4ea3580dd533ee1cbf9e8f636a128e4374d8315d [diff]
Remove cancel message in favor of CANCELED error type.

Most code doesn't care to distinguish between an error and cancelation,
as both abort the transfer. The few places that do care (e.g., the code
that decides whether to show an error to the user) can explicitly check
the type. This also allows cancellation to be easily propagated through
the error path from the source, instead of requiring a secondary
cancellation path.

Bug: 679313
Change-Id: I3c90ff55e7a58043535244a9d92cfc9e6814a4e6
Reviewed-on: https://chromium-review.googlesource.com/c/1437657
Commit-Queue: Erik Jensen <rkjnsn@chromium.org>
Reviewed-by: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626294}
2 files changed
tree: 3dfc8cb8ac4cab4733de5a9c0320b8ed4940cf44
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. cc/
  8. chrome/
  9. chrome_elf/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .