Disable KHR_blend_equation_advanced(_coherent) until cc shaders are updated

Disable KHR_blend_equation_advanced(_coherent) until cc shaders are updated

BUG=661715
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/b5066b11a59f5b79aab006373533b8a191784a57
Cr-Commit-Position: refs/heads/master@{#435350}

[Kai Ninomiya, 2016-11-30 00:45:05]

Description was changed from

==========
Disable KHR_blend_equation_advanced(_coherent) until cc shaders are updated

BUG=661715
==========

to

==========
Disable KHR_blend_equation_advanced(_coherent) until cc shaders are updated

BUG=661715
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Kai Ninomiya, 2016-11-30 00:48:35]

kainino@chromium.org changed reviewers:
+ kbr@chromium.org

[Kai Ninomiya, 2016-11-30 00:48:35]

kbr, PTAL

[Ken Russell (switch to Gerrit), 2016-11-30 00:56:23]

lgtm

enne, danakj, ericrk, bsalomon: not sure who on the team is most interested in
using KHR_blend_equation_advanced, but the shaders need to be updated for it --
they break (correctly) on Mesa 13.0. Disabling these extensions temporarily.

[Ken Russell (switch to Gerrit), 2016-11-30 00:56:27]

The CQ bit was checked by kbr@chromium.org

[commit-bot: I haz the power, 2016-11-30 00:57:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-30 03:00:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-30 03:00:12]

Try jobs failed on following builders:
  blimp_linux_dbg on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_optional_gpu_tests_rel on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)

[Ken Russell (switch to Gerrit), 2016-11-30 03:50:56]

On 2016/11/30 03:00:12, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   blimp_linux_dbg on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
> URL)
>   cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
> URL)
>   chromeos_amd64-generic_chromium_compile_only_ng on
> master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
>   chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
> (JOB_TIMED_OUT, no build URL)
>   chromeos_x86-generic_chromium_compile_only_ng on
> master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
>   linux_chromium_asan_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT,
> no build URL)
>   linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
> (JOB_TIMED_OUT, no build URL)
>   linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
> (JOB_TIMED_OUT, no build URL)
>   linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
> (JOB_TIMED_OUT, no build URL)
>   linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux
> (JOB_TIMED_OUT, no build URL)
>   linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
> (JOB_TIMED_OUT, no build URL)
>   linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
> build URL)
>   linux_optional_gpu_tests_rel on master.tryserver.chromium.linux
> (JOB_TIMED_OUT, no build URL)

That's http://crbug.com/669297 . Not sure there's any point in retrying yet;
looks like there's a total outage of master.tryserver.chromium.linux right now.

[bsalomon, 2016-11-30 13:49:07]

On 2016/11/30 00:56:23, Ken Russell wrote:
> lgtm
> 
> enne, danakj, ericrk, bsalomon: not sure who on the team is most interested in
> using KHR_blend_equation_advanced, but the shaders need to be updated for it
--
> they break (correctly) on Mesa 13.0. Disabling these extensions temporarily.

Skia makes use of these extensions, though we have (slow) workarounds for when
they are unavailable. Are CC's shaders not using the blend_support qualifier
string correctly?

[Kai Ninomiya, 2016-11-30 16:59:15]

On 2016/11/30 13:49:07, bsalomon wrote:
> On 2016/11/30 00:56:23, Ken Russell wrote:
> > lgtm
> > 
> > enne, danakj, ericrk, bsalomon: not sure who on the team is most interested
in
> > using KHR_blend_equation_advanced, but the shaders need to be updated for it
> --
> > they break (correctly) on Mesa 13.0. Disabling these extensions temporarily.
> 
> Skia makes use of these extensions, though we have (slow) workarounds for when
> they are unavailable. Are CC's shaders not using the blend_support qualifier
> string correctly?

That's correct. The analysis done by Xinghua shows the shader in question:
https://bugs.chromium.org/p/chromium/issues/detail?id=661715#c12

[Kai Ninomiya, 2016-11-30 17:31:20]

The CQ bit was checked by kainino@chromium.org

[commit-bot: I haz the power, 2016-11-30 17:32:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-30 18:35:18]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480527080365990,
"parent_rev": "e9dbe8dcea741e64ffe88af8ab589824aca64481", "commit_rev":
"298780096679e396290ec848eb7abc4a8d8abf8c"}

[commit-bot: I haz the power, 2016-11-30 18:35:50]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-30 18:39:41]

Description was changed from

==========
Disable KHR_blend_equation_advanced(_coherent) until cc shaders are updated

BUG=661715
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Disable KHR_blend_equation_advanced(_coherent) until cc shaders are updated

BUG=661715
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/b5066b11a59f5b79aab006373533b8a191784a57
Cr-Commit-Position: refs/heads/master@{#435350}
==========

[commit-bot: I haz the power, 2016-11-30 18:39:42]

Patchset 2 (id:??) landed as
https://crrev.com/b5066b11a59f5b79aab006373533b8a191784a57
Cr-Commit-Position: refs/heads/master@{#435350}